Skip to content

Commit 2f11dfa

Browse files
bkamin29morgante
authored andcommitted
Fix: Add Terraform 0.12 support to bucket_force_destroy boolean variable (#24)
* change from string to bool * generate docs and make a test
1 parent 0040945 commit 2f11dfa

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Then perform the following commands on the root folder:
3838

3939
| Name | Description | Type | Default | Required |
4040
|------|-------------|:----:|:-----:|:-----:|
41-
| bucket\_force\_destroy | When deleting the GCS bucket containing the cloud function, delete all objects in the bucket first. | string | `"true"` | no |
41+
| bucket\_force\_destroy | When deleting the GCS bucket containing the cloud function, delete all objects in the bucket first. | bool | `"true"` | no |
4242
| bucket\_name | The name to apply to the bucket. Will default to a string of <project-id>-scheduled-function-XXXX> with XXXX being random characters. | string | `""` | no |
4343
| function\_available\_memory\_mb | The amount of memory in megabytes allotted for the function to use. | number | `"256"` | no |
4444
| function\_description | The description of the function. | string | `"Processes log export events provided through a Pub/Sub topic subscription."` | no |

variables.tf

+2-2
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ variable "bucket_name" {
117117
}
118118

119119
variable "bucket_force_destroy" {
120-
type = "string"
121-
default = "true"
120+
type = bool
121+
default = true
122122
description = "When deleting the GCS bucket containing the cloud function, delete all objects in the bucket first."
123123
}
124124

0 commit comments

Comments
 (0)