Skip to content

feat: allow tls_save_ca_to_disk to also chose the filename of the full path of the local CA public certificate copy #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2022
Merged

feat: allow tls_save_ca_to_disk to also chose the filename of the full path of the local CA public certificate copy #165

merged 3 commits into from
Nov 17, 2022

Conversation

boeboe
Copy link
Contributor

@boeboe boeboe commented Nov 14, 2022 •
edited by apeabody
Loading

Fixes #164

@boeboe
implement feature request 164 (Allow tls_save_ca_to_disk to also chos…
70185d7 
…e the filename of the full path of the local CA public certificate copy)
@boeboe boeboe requested a review from a team as a code owner November 14, 2022 13:10
@boeboe boeboe mentioned this pull request Nov 14, 2022
Closed
@comment-bot-dev
Copy link

comment-bot-dev commented Nov 14, 2022 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody
Copy link
Contributor

Hi @boeboe - Thanks for the contribution!

Can you please run make docker_generate_docs and add the changes to your Pull Request.

Thanks!

@apeabody apeabody changed the title Allow tls_save_ca_to_disk to also chose the filename of the full path of the local CA public certificate copy feat: allow tls_save_ca_to_disk to also chose the filename of the full path of the local CA public certificate copy Nov 16, 2022
@apeabody apeabody mentioned this pull request Nov 16, 2022
Merged
@apeabody apeabody self-assigned this Nov 16, 2022
@boeboe
Copy link
Contributor Author

boeboe commented Nov 16, 2022

Thanks @apeabody . Added the missing documentation entries to this PR after running make docker_generate_docs.

@apeabody
Copy link
Contributor

Thanks for the contribution @boeboe!

@apeabody apeabody merged commit 3f78888 into terraform-google-modules:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow tls_save_ca_to_disk to also chose the filename of the full path of the local CA public certificate copy
3 participants
@boeboe @comment-bot-dev @apeabody