Skip to content

Pulled Vault core into a separate submodule #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 21, 2020

Conversation

onetwopunch
Copy link
Contributor

Fixes #98

Breaking change, major release.

This refactor pulls out the server, tls and load balancer resources into their own module called cluster so that larger enterprises that have separate teams to configure things like buckets, firewalls, networks, and service accounts can still use the core Vault logic.

@onetwopunch onetwopunch requested a review from a team as a code owner July 17, 2020 05:29
@onetwopunch onetwopunch removed the wip label Jul 17, 2020
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nits I saw 😃

@morgante morgante requested a review from bharathkkb July 21, 2020 15:00
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onetwopunch onetwopunch merged commit b4b39ab into terraform-google-modules:master Jul 21, 2020
@release-please release-please bot mentioned this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull server and load balancer config into a submodule
2 participants