Add diff suppress for empty/default pod_security_policy_config #1670
Conversation
|
accidently deleted the remote branch herp |
google/resource_container_cluster.go
Outdated
| @@ -1555,3 +1556,17 @@ func masterAuthClientCertCfgSuppress(k, old, new string, r *schema.ResourceData) | |||
|
|
|||
| return strings.HasSuffix(k, ".issue_client_certificate") && old == "" && new == "true" | |||
| } | |||
|
|
|||
| func podSecurityPolicyCfgSuppress(k, old, new string, r *schema.ResourceData) bool { | |||
| if strings.HasSuffix(k, "pod_security_policy_config.#") && old == "1" && new == "0" { | |||
There was a problem hiding this comment.
The HasSuffix doesn't make much sense if the next step is to GetOk an unprefixed pod_security_policy_config - should it just be '=='?
There was a problem hiding this comment.
I wasn't sure if k actually starts with pod_security_policy_config or has resource-specific naming prefix (i.e. google_container_cluster.my_cluster.pod_security_policy_config.#). Since it wasn't the same value necessarily as the keys for r, I thought I'd err on the cautious side but I can change it.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #1667