strpos -> str_contains

a simple commit to make this consistent before I do some more serious work

Author: shish

generator/src/Generator/ComposerJsonEditor.php

@@ -38,7 +38,7 @@ public static function editComposerFileForGeneration(array $modules): void
     public static function editFilesListForGeneration(array $oldFiles, array $modules): array
     {
         $files = array_values(array_filter($oldFiles, function ($file) {
-            return strpos($file, 'generated/') === false;
+            return !str_contains($file, 'generated/');
         }));
         foreach ($modules as $module) {
             $files[] = 'generated/'.lcfirst($module).'.php';

generator/src/PhpStanFunctions/PhpStanParameter.php

@@ -12,7 +12,7 @@ class PhpStanParameter
     public function __construct(string $name, string $type)
     {
         $writeOnly = false;
-        if (\strpos($name, '&w_') !== false) {
+        if (str_contains($name, '&w_')) {
             $writeOnly = true;
         }
         $name = \str_replace(['&rw_', '&w_'], '', $name);

generator/src/PhpStanFunctions/PhpStanType.php

@@ -73,8 +73,7 @@ public function __construct(string|\SimpleXMLElement $data, bool $writeOnly = fa
             $returnType = '';
         }
         foreach ($returnTypes as &$returnType) {
-            $pos = \strpos($returnType, '?');
-            if ($pos !== false) {
+            if (str_contains($returnType, '?')) {
                 $nullable = true;
                 $returnType = \str_replace('?', '', $returnType);
             }
@@ -178,17 +177,17 @@ public function getSignatureType(?int $errorType = null): string
         }
 
         foreach ($types as &$type) {
-            if (\strpos($type, 'callable(') > -1) {
+            if (str_contains($type, 'callable(')) {
                 $type = 'callable'; //strip callable type of its possible parenthesis and return (ex: callable(): void)
-            } elseif (\strpos($type, 'array<') !== false || \strpos($type, 'array{') !== false) {
+            } elseif (str_contains($type, 'array<') || str_contains($type, 'array{')) {
                 $type = 'array'; //typed array has to be untyped
-            } elseif (\strpos($type, '[]') !== false) {
+            } elseif (str_contains($type, '[]')) {
                 $type = 'iterable'; //generics cannot be typehinted and have to be turned into iterable
-            } elseif (\strpos($type, 'resource') !== false) {
+            } elseif (str_contains($type, 'resource')) {
                 $type = ''; // resource cant be typehinted
-            } elseif (\strpos($type, 'null') !== false) {
+            } elseif (str_contains($type, 'null')) {
                 $type = ''; // null is a real typehint
-            } elseif (\strpos($type, 'true') !== false) {
+            } elseif (str_contains($type, 'true')) {
                 $type = 'bool'; // php8.1 doesn't support "true" as a typehint
             }
         }

generator/src/XmlDocParser/Parameter.php

@@ -68,7 +68,7 @@ public function isOptionalWithNoDefault(): bool
 
         $initializer = $this->getInitializer();
         // Some default value have weird values. For instance, first parameter of "mb_internal_encoding" has default value "mb_internal_encoding()"
-        if ($initializer === 'null' || ($initializer !== 'array()' && strpos($initializer, '(') !== false)) {
+        if ($initializer === 'null' || ($initializer !== 'array()' && str_contains($initializer, '('))) {
             return true;
         }
         return false;
@@ -110,7 +110,7 @@ public function getDefaultValue(): ?string
         $initializer = $this->getInitializer();
 
         // Some default value have weird values. For instance, first parameter of "mb_internal_encoding" has default value "mb_internal_encoding()"
-        if (strpos($initializer, '(') !== false) {
+        if (str_contains($initializer, '(')) {
             return null;
         }