Migrate the forgotten unused AddClusterIT and basic_reaper_functionality.feature into BasicSteps and integration_reaper_functionality.feature

 - Migrate scenarios from basic_reaper_functionality.feature into integration_reaper_functionality.feature
 - Remove Incremental/NoIncremental class variations where they are not used.
 - Remove `@full` annotation, as only presence @incremental is ever checked.
 - Small fix to RepairScheduleService.isConflictingSchedules(..)
 - Remove failsafe plugin from pom as it's not used.
 – reduce log noise in integration tests
 – consistent ccm datacenter names in CI, and correctly configured DcAwareLoadBalancing policy (localDC is always 'dc1')
 – in BasicSteps assert that responses are only empty on against 2xx responses
 – in ReaperTestJettyRunner ignore interruption exceptions during test shutdown

ref: https://github.com/thelastpickle/cassandra-reaper/pull/495/files

Author: michaelsembwever

.circleci/config.yml

@@ -107,9 +107,6 @@ aliases:
                 MAVEN_OPTS="-Xmx1g" mvn install -DskipTests
                 sh -c '$JOB_COMMAND'
 
-                #TODO
-                #mvn surefire:test -DsurefireArgLine="-Xmx1g" -Dtest=ReaperCassandraIncrementalIT -Dgrim.reaper.min=2 -Dgrim.reaper.max=4
-
         - store_test_results:
             path: src/server/target/surefire-reports
 

src/ci/install.sh

@@ -17,7 +17,8 @@ case "${TEST_TYPE}" in
         echo "cassandra     readwrite" >> /usr/lib/jvm/java-8-oracle/jre/lib/management/jmxremote.access
         cat /usr/lib/jvm/java-8-oracle/jre/lib/management/jmxremote.access
         ccm create test -v $CASSANDRA_VERSION > /dev/null
-        ccm populate --vnodes -n 2 > /dev/null
+        # use "2:0" to ensure the first datacenter name is "dc1" instead of "datacenter1", so to be compatible with CircleCI tests
+        ccm populate --vnodes -n 2:0 > /dev/null
         sed -i 's/etc\/cassandra\/jmxremote.password/home\/travis\/.local\/jmxremote.password/' /home/travis/.ccm/test/node1/conf/cassandra-env.sh
         sed -i 's/etc\/cassandra\/jmxremote.password/home\/travis\/.local\/jmxremote.password/' /home/travis/.ccm/test/node2/conf/cassandra-env.sh
         sed -i 's/#MAX_HEAP_SIZE="4G"/MAX_HEAP_SIZE="192m"/' /home/travis/.ccm/test/node1/conf/cassandra-env.sh

src/server/pom.xml

@@ -311,29 +311,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-failsafe-plugin</artifactId>
-                <version>2.21.0</version>
-                <executions>
-                  <execution>
-                    <id>integration-tests</id>
-                    <goals>
-                      <goal>integration-test</goal>
-                      <goal>verify</goal>
-                    </goals>
-                    <configuration>
-                      <skipTests>true</skipTests>
-                      <argLine>${failsafeArgLine}</argLine>
-                      <failIfNoTests>false</failIfNoTests>
-                      <includes>
-                        <include>**/AddClusterIT.java</include>
-                        <include>**/ReaperIT.java</include>
-                      </includes>
-                    </configuration>
-                  </execution>
-                </executions>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>