fix: backfill missing metronome Ids #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adilansari
force-pushed
the
metronome-backfill
branch
2 times, most recently
from
5fe6964 to
a644f9f
Compare
adilansari
changed the title
adilansari
force-pushed
the
metronome-backfill
branch
from
a2b4555 to
3596ae9
Compare
himank
reviewed
May 18, 2023
| } | ||
| } else { | ||
| // check if we received HTTP 409 from billing svc, in that case namespaceId already exists there | ||
| var metronomeError *MetronomeError |
There was a problem hiding this comment.
You can move this to a helper method, IsBillingAccountExists
himank
previously approved these changes
May 18, 2023
|
pushing because initial version was anyways approved except the last 1 liner change in unit tests. |
|
🎉 This PR is included in version 1.0.0-beta.103 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
adilansari
added a commit
that referenced
this pull request
May 18, 2023
This reverts commit 50536f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
How best to test these changes
Issue ticket number and link