refactor: refactor metronome metrics with consistent tags #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboros
force-pushed
the
pboros/metronome-metrics-refactor
branch
8 times, most recently
from
029d917 to
31aefea
Compare
pboros
force-pushed
the
pboros/metronome-metrics-refactor
branch
2 times, most recently
from
c2f38a1 to
d522585
Compare
pboros
added
debug image
himank
reviewed
Jun 1, 2023
| @@ -93,6 +94,9 @@ func SchemaUpdateRepaired(project string, branch string, collection string) { | |||
| } | |||
|
|
|||
| func InitializeMetrics() func() { | |||
adilansari
reviewed
Jun 1, 2023
himank
reviewed
Jun 1, 2023
server/metrics/metrics.go
Outdated
| @@ -93,6 +94,9 @@ func SchemaUpdateRepaired(project string, branch string, collection string) { | |||
| } | |||
|
|
|||
| func InitializeMetrics() func() { | |||
| if metricsInitialized { | |||
There was a problem hiding this comment.
What about instead of this do,
var once sync.Once
InitializeMetrics() func() {
once.Do(func() {})
}
There was a problem hiding this comment.
I added a mutex, which is basically the same as what this does internally. We need to pass io.Closer outside.
There was a problem hiding this comment.
You can have io.Closer outside of Do()
himank
reviewed
Jun 1, 2023
pboros
force-pushed
the
pboros/metronome-metrics-refactor
branch
3 times, most recently
from
2f138e5 to
4c52891
Compare
himank
previously approved these changes
Jun 1, 2023
pboros
force-pushed
the
pboros/metronome-metrics-refactor
branch
from
4c52891 to
0f4294c
Compare
pboros
force-pushed
the
pboros/metronome-metrics-refactor
branch
from
0f4294c to
e6de963
Compare
himank
approved these changes
Jun 1, 2023
JigarJoshi
pushed a commit
that referenced
this pull request
Jun 1, 2023
JigarJoshi
added a commit
that referenced
this pull request
Jun 1, 2023
* refactor: refactor metronome metrics with consistent tags (#1241) * feat: Implemented API key authentication mechanism * fix: Fixed marshaling based on code review suggestion * feat: Added whoami endpoint * refactor: minor refactor based on code review comments --------- Co-authored-by: Peter Boros <[email protected]>
|
🎉 This PR is included in version 1.0.0-beta.112 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactor metronome metrics to be in-line with the rest and make sure tags won't be different in the same scope.
Right now the new metrics are additional to the old, one, needs to be deleted.
How best to test these changes
Check the metronome alerts in dev.
Issue ticket number and link
TIG-1549