Skip to content

feat: build debug images with symbols enabled for releases and ad-hoc #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

rbarabas
Copy link
Contributor

@rbarabas rbarabas commented May 30, 2023

Describe your changes

Adds the option to compile our binaries with debugging symbols. This is currently only enabled for the server binaries.

Removes old, duplicate CI job that created ad-hoc images for PRs which were also called debug images but had no debug symbols in the binaries. Now ad-hoc image builds are created with debugging symbols by default.

Features

  • delve added to the build image
  • WITH_DEBUG enables compiling with debugging symbols

How best to test these changes

Check output of the build action

Issue ticket number and link

https://tigrisdata.atlassian.net/browse/TIG-1550


❯ WITH_DEBUG=1 make server
make -C api/proto generate GEN_DIR=../../api/server/v1 API_DIR=..
make[1]: Nothing to be done for `generate'.
...
CGO_ENABLED=1 go build -tags=release -ldflags "-X 'github.com/tigrisdata/tigris/util.Version=6b8ca30' -X 'github.com/tigrisdata/tigris/util.BuildHash=6b8ca30'"  -gcflags "all=-N -l" -o server/service ./server

@reviewpad reviewpad bot added the medium label May 30, 2023
@rbarabas rbarabas changed the title feat: add delve to base build image feat: debug images for Tigris May 30, 2023
@reviewpad reviewpad bot added the large label May 30, 2023
@rbarabas rbarabas requested a review from efirs May 30, 2023 22:54
@rbarabas rbarabas marked this pull request as ready for review May 30, 2023 22:58
@rbarabas rbarabas requested a review from himank May 30, 2023 22:58
JigarJoshi
JigarJoshi previously approved these changes May 30, 2023
@rbarabas rbarabas force-pushed the rb/debug-builds branch 2 times, most recently from 31d8519 to 02cda00 Compare May 30, 2023 23:07
@rbarabas rbarabas requested a review from JigarJoshi May 30, 2023 23:15
@rbarabas rbarabas force-pushed the rb/debug-builds branch 9 times, most recently from a9a2d22 to adca899 Compare June 2, 2023 14:25
@rbarabas rbarabas changed the title feat: debug images for Tigris feat: build debug images with symbols enabled for releases and ad-hoc Jun 2, 2023
@rbarabas rbarabas force-pushed the rb/debug-builds branch 2 times, most recently from cd03d9b to 190fb37 Compare June 2, 2023 17:25
@rbarabas rbarabas force-pushed the rb/debug-builds branch 2 times, most recently from f7c8560 to 3145fbe Compare June 5, 2023 15:03
@rbarabas rbarabas requested a review from efirs June 5, 2023 15:04
@rbarabas rbarabas added the debug image This PR will generate a debug image label Jun 5, 2023
@rbarabas rbarabas merged commit 32b225b into main Jun 5, 2023
@rbarabas rbarabas deleted the rb/debug-builds branch June 5, 2023 16:15
@tigrisdata-argocd-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-beta.114 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug image This PR will generate a debug image large medium released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants