Skip to content

Commit 56187f1

Browse files
jhprattjhpratt
committed
Remove region markers
While neat, they're rarely used in practice.
1 parent 1bc4ce0 commit 56187f1

23 files changed

+0
-222
lines changed

Diff for: ‎benchmarks/date.rs

-8
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ const DATES: [Date; 24] = [
3535
setup_benchmark! {
3636
"Date",
3737

38-
// region: constructors
3938
fn from_calendar_date(ben: &mut Bencher<'_>) {
4039
ben.iter(|| Date::from_calendar_date(2019, Month::January, 1));
4140
ben.iter(|| Date::from_calendar_date(2019, Month::December, 31));
@@ -66,9 +65,7 @@ setup_benchmark! {
6665
}
6766
});
6867
}
69-
// endregion constructors
7068

71-
// region: getters
7269
fn year(ben: &mut Bencher<'_>) {
7370
let d = date!(2019-002);
7471
ben.iter(|| d.year());
@@ -177,9 +174,7 @@ setup_benchmark! {
177174
}
178175
});
179176
}
180-
// endregion getters
181177

182-
// region: attach time
183178
fn midnight(ben: &mut Bencher<'_>) {
184179
ben.iter(|| date!(1970-01-01).midnight());
185180
}
@@ -203,9 +198,7 @@ setup_benchmark! {
203198
fn with_hms_nano(ben: &mut Bencher<'_>) {
204199
ben.iter(|| date!(1970-01-01).with_hms_nano(0, 0, 0, 0));
205200
}
206-
// endregion attach time
207201

208-
// region: trait impls
209202
fn add(ben: &mut Bencher<'_>) {
210203
let dt = 5.days();
211204
ben.iter(|| date!(2019-01-01) + dt);
@@ -281,5 +274,4 @@ setup_benchmark! {
281274
ben.iter(|| first.cmp(&second));
282275
ben.iter(|| second.cmp(&first));
283276
}
284-
// endregion trait impls
285277
}

Diff for: ‎benchmarks/duration.rs

-14
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ use time::Duration;
77
setup_benchmark! {
88
"Duration",
99

10-
// region: is_{sign}
1110
fn is_zero(ben: &mut Bencher<'_>) {
1211
let a = (-1).nanoseconds();
1312
let b = 0.seconds();
@@ -34,9 +33,7 @@ setup_benchmark! {
3433
ben.iter(|| b.is_positive());
3534
ben.iter(|| c.is_positive());
3635
}
37-
// endregion is_{sign}
3836

39-
// region: abs
4037
fn abs(ben: &mut Bencher<'_>) {
4138
let a = 1.seconds();
4239
let b = 0.seconds();
@@ -54,9 +51,7 @@ setup_benchmark! {
5451
ben.iter(|| b.unsigned_abs());
5552
ben.iter(|| c.unsigned_abs());
5653
}
57-
// endregion abs
5854

59-
// region: constructors
6055
fn new(ben: &mut Bencher<'_>) {
6156
ben.iter(|| Duration::new(1, 0));
6257
ben.iter(|| Duration::new(-1, 0));
@@ -172,9 +167,7 @@ setup_benchmark! {
172167
ben.iter(|| c.whole_weeks());
173168
ben.iter(|| d.whole_weeks());
174169
}
175-
// endregion constructors
176170

177-
// region: getters
178171
fn whole_days(ben: &mut Bencher<'_>) {
179172
let a = Duration::days(1);
180173
let b = Duration::days(-1);
@@ -302,9 +295,7 @@ setup_benchmark! {
302295
ben.iter(|| a.subsec_nanoseconds());
303296
ben.iter(|| b.subsec_nanoseconds());
304297
}
305-
// endregion getters
306298

307-
// region: checked arithmetic
308299
fn checked_add(ben: &mut Bencher<'_>) {
309300
let a = 5.seconds();
310301
let b = Duration::MAX;
@@ -345,9 +336,7 @@ setup_benchmark! {
345336
ben.iter(|| a.checked_div(2));
346337
ben.iter(|| a.checked_div(0));
347338
}
348-
// endregion checked arithmetic
349339

350-
// region: saturating arithmetic
351340
fn saturating_add(ben: &mut Bencher<'_>) {
352341
let a = 5.seconds();
353342
let b = Duration::MAX;
@@ -399,9 +388,7 @@ setup_benchmark! {
399388
ben.iter(|| f.saturating_mul(-2));
400389
ben.iter(|| g.saturating_mul(-2));
401390
}
402-
// endregion saturating arithmetic
403391

404-
// region: trait impls
405392
fn try_from_std_duration(ben: &mut Bencher<'_>) {
406393
let a = 0.std_seconds();
407394
let b = 1.std_seconds();
@@ -724,5 +711,4 @@ setup_benchmark! {
724711
ben.iter(|| d > a);
725712
ben.iter(|| e < c);
726713
}
727-
// endregion trait impls
728714
}

Diff for: ‎benchmarks/instant.rs

-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ use time::{Duration, Instant};
99
setup_benchmark! {
1010
"Instant",
1111

12-
// region: checked arithmetic
1312
fn checked_add(ben: &mut Bencher<'_>) {
1413
let instant = Instant::now();
1514
let dt = 5.seconds();
@@ -21,9 +20,7 @@ setup_benchmark! {
2120
let dt = 5.seconds();
2221
ben.iter(|| instant.checked_sub(dt));
2322
}
24-
// endregion checked arithmetic
2523

26-
// region: trait impls
2724
fn sub(ben: &mut Bencher<'_>) {
2825
let start: Instant = Instant::now();
2926
let end: Instant = start + 1.milliseconds();
@@ -89,5 +86,4 @@ setup_benchmark! {
8986
[|instant| *instant -= dt]
9087
);
9188
}
92-
// endregion trait impls
9389
}

Diff for: ‎benchmarks/offset_date_time.rs

-10
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,19 @@ use time::OffsetDateTime;
88
setup_benchmark! {
99
"OffsetDateTime",
1010

11-
// region: now
1211
fn now_utc(ben: &mut Bencher<'_>) {
1312
ben.iter(OffsetDateTime::now_utc);
1413
}
1514

1615
fn now_local(ben: &mut Bencher<'_>) {
1716
ben.iter(OffsetDateTime::now_local);
1817
}
19-
// endregion now
2018

2119
fn to_offset(ben: &mut Bencher<'_>) {
2220
ben.iter(|| datetime!(2000-01-01 0:00 +11).to_offset(offset!(-5)));
2321
ben.iter(|| datetime!(2000-01-01 0:00 +11).to_offset(offset!(-8)));
2422
}
2523

26-
// region: constructors
2724
fn from_unix_timestamp(ben: &mut Bencher<'_>) {
2825
ben.iter(|| OffsetDateTime::from_unix_timestamp(0));
2926
ben.iter(|| OffsetDateTime::from_unix_timestamp(1_546_300_800));
@@ -33,9 +30,7 @@ setup_benchmark! {
3330
ben.iter(|| OffsetDateTime::from_unix_timestamp_nanos(0));
3431
ben.iter(|| OffsetDateTime::from_unix_timestamp_nanos(1_546_300_800_000_000_000));
3532
}
36-
// endregion constructors
3733

38-
// region: getters
3934
fn offset(ben: &mut Bencher<'_>) {
4035
ben.iter(|| datetime!(2019-01-01 0:00 UTC).offset());
4136
ben.iter(|| datetime!(2019-01-01 0:00 +1).offset());
@@ -88,9 +83,7 @@ setup_benchmark! {
8883
ben.iter(|| datetime!(2019-01-01 0:00 UTC).second());
8984
ben.iter(|| datetime!(2018-12-31 23:00 -1).second());
9085
}
91-
// endregion getters
9286

93-
// region: replacement
9487
fn replace_time(ben: &mut Bencher<'_>) {
9588
ben.iter(|| datetime!(2020-01-01 5:00 UTC).replace_time(time!(12:00)));
9689
ben.iter(|| datetime!(2020-01-01 12:00 -5).replace_time(time!(7:00)));
@@ -110,9 +103,7 @@ setup_benchmark! {
110103
fn replace_offset(ben: &mut Bencher<'_>) {
111104
ben.iter(|| datetime!(2020-01-01 0:00 UTC).replace_offset(offset!(-5)));
112105
}
113-
// endregion replacement
114106

115-
// region: trait impls
116107
fn partial_eq(ben: &mut Bencher<'_>) {
117108
ben.iter(|| datetime!(1999-12-31 23:00 -1) == datetime!(2000-01-01 0:00 UTC));
118109
}
@@ -425,5 +416,4 @@ setup_benchmark! {
425416
ben.iter(|| SystemTime::from(b));
426417
ben.iter(|| SystemTime::from(c));
427418
}
428-
// endregion trait impls
429419
}

Diff for: ‎benchmarks/primitive_date_time.rs

-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ setup_benchmark! {
88
// All getters are trivially dispatched to the relevant field, and do not need to be benchmarked
99
// a second time.
1010

11-
// region: attach offset
1211
fn assume_offset(ben: &mut Bencher<'_>) {
1312
ben.iter(|| datetime!(2019-01-01 0:00).assume_offset(offset!(UTC)));
1413
ben.iter(|| datetime!(2019-01-01 0:00).assume_offset(offset!(-1)));
@@ -17,9 +16,7 @@ setup_benchmark! {
1716
fn assume_utc(ben: &mut Bencher<'_>) {
1817
ben.iter(|| datetime!(2019-01-01 0:00).assume_utc());
1918
}
20-
// endregion attach offset
2119

22-
// region: trait impls
2320
fn add_duration(ben: &mut Bencher<'_>) {
2421
let a = 5.days();
2522
let b = 1.days();
@@ -144,5 +141,4 @@ setup_benchmark! {
144141
ben.iter(|| datetime!(2019-01-01 0:00:01).partial_cmp(&datetime!(2019-01-01 0:00)));
145142
ben.iter(|| datetime!(2019-01-01 0:00:00.000_000_001).partial_cmp(&datetime!(2019-01-01 0:00)));
146143
}
147-
// endregion trait impls
148144
}

Diff for: ‎benchmarks/time.rs

-6
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use time::Time;
88
setup_benchmark! {
99
"Time",
1010

11-
// region: constructors
1211
fn from_hms(ben: &mut Bencher<'_>) {
1312
ben.iter(|| Time::from_hms(1, 2, 3));
1413
}
@@ -24,9 +23,7 @@ setup_benchmark! {
2423
fn from_hms_nano(ben: &mut Bencher<'_>) {
2524
ben.iter(|| Time::from_hms_nano(1, 2, 3, 4));
2625
}
27-
// endregion constructors
2826

29-
// region: getters
3027
fn as_hms(ben: &mut Bencher<'_>) {
3128
ben.iter(|| Time::MIDNIGHT.as_hms());
3229
}
@@ -66,9 +63,7 @@ setup_benchmark! {
6663
fn nanosecond(ben: &mut Bencher<'_>) {
6764
ben.iter(|| Time::MIDNIGHT.nanosecond());
6865
}
69-
// endregion getters
7066

71-
// region: trait impls
7267
fn add_duration(ben: &mut Bencher<'_>) {
7368
let a = 1.milliseconds();
7469
let b = 1.seconds();
@@ -267,5 +262,4 @@ setup_benchmark! {
267262
criterion::BatchSize::SmallInput
268263
)
269264
}
270-
// endregion trait impls
271265
}

Diff for: ‎benchmarks/utc_offset.rs

-6
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,14 @@ use time::{OffsetDateTime, UtcOffset};
44
setup_benchmark! {
55
"UtcOffset",
66

7-
// region: constructors
87
fn from_hms(ben: &mut Bencher<'_>) {
98
ben.iter(|| UtcOffset::from_hms(0, 0, 0));
109
}
1110

1211
fn from_whole_seconds(ben: &mut Bencher<'_>) {
1312
ben.iter(|| UtcOffset::from_whole_seconds(0));
1413
}
15-
// endregion constructors
1614

17-
// region: getters
1815
fn as_hms(ben: &mut Bencher<'_>) {
1916
ben.iter(|| UtcOffset::UTC.as_hms());
2017
}
@@ -38,9 +35,7 @@ setup_benchmark! {
3835
fn seconds_past_minute(ben: &mut Bencher<'_>) {
3936
ben.iter(|| UtcOffset::UTC.seconds_past_minute());
4037
}
41-
// endregion getters
4238

43-
// region: is_{sign}
4439
fn is_utc(ben: &mut Bencher<'_>) {
4540
ben.iter(|| UtcOffset::UTC.is_utc());
4641
}
@@ -52,7 +47,6 @@ setup_benchmark! {
5247
fn is_negative(ben: &mut Bencher<'_>) {
5348
ben.iter(|| UtcOffset::UTC.is_negative());
5449
}
55-
// endregion is_{sign}
5650

5751
fn local_offset_at(ben: &mut Bencher<'_>) {
5852
ben.iter(|| UtcOffset::local_offset_at(OffsetDateTime::UNIX_EPOCH));

Diff for: ‎tests/parse_format_description.rs

-2
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,6 @@ fn errors() {
209209
}
210210
}
211211

212-
// region: individual components
213212
macro_rules! placeholder {
214213
($($x:tt)*) => {
215214
" {}"
@@ -451,7 +450,6 @@ fn ignore_component(ignore_count: M<NonZeroU16>) {
451450
))])
452451
);
453452
}
454-
// endregion individual components
455453

456454
#[rstest]
457455
fn optional() {

Diff for: ‎time/src/date.rs

-16
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ impl Date {
7373
pub const MAX: Self =
7474
unsafe { Self::__from_ordinal_date_unchecked(MAX_YEAR, days_in_year(MAX_YEAR)) };
7575

76-
// region: constructors
7776
/// Construct a `Date` from its internal representation, the validity of which must be
7877
/// guaranteed by the caller.
7978
///
@@ -319,9 +318,7 @@ impl Date {
319318
// number is in range.
320319
unsafe { Self::from_parts(y_g, is_leap_year, ordinal as _) }
321320
}
322-
// endregion constructors
323321

324-
// region: getters
325322
/// Whether `is_leap_year(self.year())` is `true`.
326323
///
327324
/// This method is optimized to take advantage of the fact that the value is pre-computed upon
@@ -744,9 +741,7 @@ impl Date {
744741
let days_before_year = (1461 * adj_year as i64 / 4) as i32 - century + century / 4;
745742
days_before_year + ordinal as i32 - 363_521_075
746743
}
747-
// endregion getters
748744

749-
// region: checked arithmetic
750745
/// Computes `self + duration`, returning `None` if an overflow occurred.
751746
///
752747
/// ```rust
@@ -982,9 +977,7 @@ impl Date {
982977
const_try_opt!(self.checked_prev_occurrence(weekday))
983978
.checked_sub(Duration::weeks(n as i64 - 1))
984979
}
985-
// endregion: checked arithmetic
986980

987-
// region: saturating arithmetic
988981
/// Computes `self + duration`, saturating value on overflow.
989982
///
990983
/// ```rust
@@ -1064,9 +1057,7 @@ impl Date {
10641057
Self::MIN
10651058
}
10661059
}
1067-
// endregion saturating arithmetic
10681060

1069-
// region: replacement
10701061
/// Replace the year. The month and day will be unchanged.
10711062
///
10721063
/// ```rust
@@ -1193,10 +1184,8 @@ impl Date {
11931184
// Safety: `ordinal` is in range.
11941185
Ok(unsafe { Self::__from_ordinal_date_unchecked(self.year(), ordinal) })
11951186
}
1196-
// endregion replacement
11971187
}
11981188

1199-
// region: attach time
12001189
/// Methods to add a [`Time`] component, resulting in a [`PrimitiveDateTime`].
12011190
impl Date {
12021191
/// Create a [`PrimitiveDateTime`] using the existing date. The [`Time`] component will be set
@@ -1302,9 +1291,7 @@ impl Date {
13021291
))
13031292
}
13041293
}
1305-
// endregion attach time
13061294

1307-
// region: formatting & parsing
13081295
#[cfg(feature = "formatting")]
13091296
impl Date {
13101297
/// Format the `Date` using the provided [format description](crate::format_description).
@@ -1441,9 +1428,7 @@ impl fmt::Debug for Date {
14411428
fmt::Display::fmt(self, f)
14421429
}
14431430
}
1444-
// endregion formatting & parsing
14451431

1446-
// region: trait impls
14471432
impl Add<Duration> for Date {
14481433
type Output = Self;
14491434

@@ -1503,4 +1488,3 @@ impl Sub for Date {
15031488
Duration::days((self.to_julian_day() - other.to_julian_day()).extend())
15041489
}
15051490
}
1506-
// endregion trait impls

0 commit comments

Comments
 (0)