add better ytdlp error logging

Author: topi314

main/src/main/java/com/github/topi314/lavasrc/ytdlp/YtdlpAudioSourceManager.java

@@ -9,14 +9,17 @@
 import com.sedmelluq.discord.lavaplayer.tools.io.HttpInterface;
 import com.sedmelluq.discord.lavaplayer.tools.io.HttpInterfaceManager;
 import com.sedmelluq.discord.lavaplayer.track.*;
+import org.apache.commons.io.IOUtils;
 import org.apache.http.client.config.RequestConfig;
 import org.apache.http.impl.client.HttpClientBuilder;
 import org.jetbrains.annotations.NotNull;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.io.BufferedInputStream;
 import java.io.DataInput;
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.function.Consumer;
@@ -169,7 +172,7 @@ public AudioItem getItem(String identifier) throws IOException {
 		var args = new ArrayList<>(List.of(this.customLoadArgs));
 		args.add(identifier);
 		var process = getProcess(args);
-		var json = JsonBrowser.parse(process.getInputStream());
+		var json = getProcessJsonOutput(process);
 
 		var type = json.get("_type").text();
 		switch (type) {
@@ -187,6 +190,7 @@ Process getProcess(List<String> args) {
 		argList.add(this.path);
 		argList.addAll(args);
 
+		log.debug("Starting yt-dlp with args: {}", argList);
 		var processBuilder = new ProcessBuilder(argList);
 		processBuilder.redirectErrorStream(true);
 
@@ -198,6 +202,28 @@ Process getProcess(List<String> args) {
 		}
 	}
 
+	JsonBrowser getProcessJsonOutput(Process process) throws IOException {
+		try (var stream = new BufferedInputStream(process.getInputStream())) {
+			var data = IOUtils.toString(stream, StandardCharsets.UTF_8);
+			log.debug("yt-dlp process output: {}", data);
+			int exitCode;
+			try {
+				exitCode = process.waitFor();
+			} catch (InterruptedException e) {
+				Thread.currentThread().interrupt();
+				throw new IOException("yt-dlp process was interrupted", e);
+			}
+			if (exitCode != 0) {
+				throw new RuntimeException("Failed to retrieve item, error: " + data);
+			}
+			try {
+				return JsonBrowser.parse(data);
+			} catch (IOException e) {
+				throw new IOException("Failed to parse yt-dlp output as JSON: " + data, e);
+			}
+		}
+	}
+
 	@Override
 	public void shutdown() {
 		try {

main/src/main/java/com/github/topi314/lavasrc/ytdlp/YtdlpAudioTrack.java

@@ -10,14 +10,11 @@
 import com.sedmelluq.discord.lavaplayer.track.AudioTrack;
 import com.sedmelluq.discord.lavaplayer.track.AudioTrackInfo;
 import com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor;
-import org.apache.commons.io.IOUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.BufferedInputStream;
 import java.io.IOException;
 import java.net.URI;
-import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -40,22 +37,7 @@ private JsonBrowser getStreamUrl(String url) throws IOException {
 		var args = new ArrayList<>(List.of(this.sourceManager.getCustomPlaybackArgs()));
 		args.add(url);
 		var process = this.sourceManager.getProcess(args);
-		try (var stream = new BufferedInputStream(process.getInputStream())) {
-			var data = IOUtils.toString(stream, StandardCharsets.UTF_8);
-
-			int exitCode;
-			try {
-				exitCode = process.waitFor();
-			} catch (InterruptedException e) {
-				Thread.currentThread().interrupt();
-				throw new IOException("yt-dlp process was interrupted", e);
-			}
-			if (exitCode == 0) {
-				return JsonBrowser.parse(data);
-			} else {
-				throw new RuntimeException("Failed to retrieve stream URL, error: " + data);
-			}
-		}
+		return this.sourceManager.getProcessJsonOutput(process);
 	}
 
 	@Override