Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Sinter should not attempt to connect to a sync server if none configured #59

Open
mike-myers-tob opened this issue May 14, 2020 · 1 comment
Labels
bug Something isn't working sync server Related to the server that controls the agent

Comments

@mike-myers-tob
Copy link
Contributor

mike-myers-tob commented May 14, 2020

Why

As a security engineer, I only want Sinter to attempt a connection to a sync server if one is configured so that my logs are not filled with failed attempt messages.

Acceptance Criteria:

  • If there is not sync server URL provided in the local Sinter config, do not attempt to contact a sync server and do not output an error log.
  • If a sync server is configured but Sinter cannot connect to it for any other reason, emit an error to the logs.
@mike-myers-tob mike-myers-tob added bug Something isn't working sync server Related to the server that controls the agent labels May 14, 2020
@mike-myers-tob mike-myers-tob added this to the Minimum Viable Product milestone May 14, 2020
@mike-myers-tob mike-myers-tob self-assigned this May 14, 2020
@mike-myers-tob
Copy link
Contributor Author

So in examining how Sinter behaves currently:

  1. If there is a sync-server config but the decision-manager is set to "local": it doesn't matter what's in the sync-server URL, as it is ignored.
  2. If there is a sync-server config, the decision-manager is set to "sync-server" and the URL setting is simply missing, then Sinter outputs an error message about that and quits.
  3. If there is a sync-server config, the decision-manager is set to "sync-server" and the URL setting is a URL where no sync-server is currently running, Sinter attempts to reconnect on an interval, but this is by design. I think you want this.
  4. there is a sync-server config, the decision-manager is set to "sync-server" and the URL setting is "" (an empty string, or some other string that does not constitute a real URL), then Sinter fails to understand that and attempts to connect to that bad URL on the interval. This is probably a bug and it should quit immediately like in case 2.

@alessandrogario alessandrogario removed this from the Minimum Viable Product milestone Jun 8, 2020
@mike-myers-tob mike-myers-tob removed their assignment Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working sync server Related to the server that controls the agent
Projects
None yet
Development

No branches or pull requests

2 participants