Skip to content

Commit ab8e5c6

Browse files
committed
Fix a test failure in node >=12 due to util.format edge case change
THis is a slight change in how `log.info(undefined, 'some message')` is rendered by Bunyan, but that's been a fact since node v12. nodejs/node#23162 was the relevant change.
1 parent b6f73f3 commit ab8e5c6

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

test/log.test.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,20 @@ var names = ['trace', 'debug', 'info', 'warn', 'error', 'fatal'];
8989
var fields = {one: 'un'};
9090

9191
test('log.info(undefined, <msg>)', function (t) {
92+
// https://github.com/nodejs/node/pull/23162 (starting in node v12) changed
93+
// util.format() handling such that this test case expected string differs.
94+
var expect;
95+
if (Number(process.versions.node.split('.')[0]) >= 12) {
96+
expect = 'undefined some message';
97+
} else {
98+
expect = 'undefined \'some message\'';
99+
}
100+
92101
names.forEach(function (lvl) {
93102
log3[lvl].call(log3, undefined, 'some message');
94103
var rec = catcher.records[catcher.records.length - 1];
95-
t.equal(rec.msg, 'undefined \'some message\'',
96-
format('log.%s msg is "some message"', lvl));
104+
t.equal(rec.msg, expect,
105+
format('log.%s(undefined, "some message")', lvl));
97106
});
98107
t.end();
99108
});

0 commit comments

Comments
 (0)