Skip to content

Commit 395b533

Browse files
damian3031wendigo
authored andcommitted
Make correct assertions about Segment type and its attributes
1 parent dad2439 commit 395b533

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

tests/integration/test_dbapi_integration.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929
import trino
3030
from tests.integration.conftest import trino_version
3131
from trino import constants
32+
from trino.client import InlineSegment
3233
from trino.client import SegmentIterator
34+
from trino.client import SpooledSegment
3335
from trino.dbapi import Cursor
3436
from trino.dbapi import DescribeOutput
3537
from trino.dbapi import TimeBoundLRUCache
@@ -1883,9 +1885,17 @@ def test_segments_cursor(trino_connection):
18831885
row_mapper = RowMapperFactory().create(columns=cur._query.columns, legacy_primitive_types=False)
18841886
total = 0
18851887
for segment in segments:
1888+
assert isinstance(segment.segment, (InlineSegment, SpooledSegment)), (
1889+
f"Expected InlineSegment or SpooledSegment, got {type(segment.segment)}"
1890+
)
18861891
assert segment.encoding == trino_connection._client_session.encoding
1887-
assert isinstance(segment.segment.uri, str), f"Expected string for uri, got {segment.segment.uri}"
1888-
assert isinstance(segment.segment.ack_uri, str), f"Expected string for ack_uri, got {segment.segment.ack_uri}"
1892+
if isinstance(segment.segment, SpooledSegment):
1893+
assert isinstance(segment.segment.uri, str), (
1894+
f"Expected string for uri, got {type(segment.segment.uri)}"
1895+
)
1896+
assert isinstance(segment.segment.ack_uri, str), (
1897+
f"Expected string for ack_uri, got {type(segment.segment.ack_uri)}"
1898+
)
18891899
total += len(list(SegmentIterator(segment, row_mapper)))
18901900
assert total == 300875, f"Expected total rows 300875, got {total}"
18911901

0 commit comments

Comments
 (0)