context manager in session fixture

Author: bmos

tests/conftest.py

@@ -17,16 +17,12 @@
 
 @pytest.fixture(params=session_parameters)
 def session(request):
-    param = request.param
-
-    if param.get("driver") == "chrome":
-        driver = selenium.webdriver.Chrome()
-        session = requestium.Session(driver=driver)
-    elif param.get("driver") == "firefox":
-        driver = selenium.webdriver.Firefox()
-        session = requestium.Session(driver=driver)
-    else:
-        session = requestium.Session(**param)
-
-    yield session
-    session.driver.quit()
+    params = request.param.copy()  # Make a copy so we don't mutate the original
+
+    if params.get("driver") == "chrome":
+        params["driver"] = selenium.webdriver.Chrome()
+    elif params.get("driver") == "firefox":
+        params["driver"] = selenium.webdriver.Firefox()
+
+    with requestium.Session(**params) as s:
+        yield s