rename + default trace margin

Author: ShiboSoftwareDev

index.ts

@@ -1,4 +1,4 @@
 export { checkEachPcbPortConnected } from "./lib/check-each-pcb-port-connected"
 export { checkEachPcbTraceNonOverlapping } from "./lib/check-each-pcb-trace-non-overlapping/check-each-pcb-trace-non-overlapping"
 export { NetManager } from "./lib/net-manager"
-export { checkViasOutOfBoard } from "./lib/check-pcb-components-out-of-board/checkViasOutOfBoard"
+export { checkViasOutOfBoard } from "./lib/check-pcb-components-out-of-board/checkViasOffBoard"

lib/check-pcb-components-out-of-board/checkViasOutOfBoard.ts renamed to lib/check-pcb-components-out-of-board/checkViasOffBoard.ts

@@ -5,8 +5,9 @@ import type {
   PcbPlacementError,
 } from "circuit-json"
 import { getReadableNameForElement } from "@tscircuit/circuit-json-util"
+import { DEFAULT_VIA_BOARD_MARGIN } from "lib/drc-defaults"
 
-export function checkViasOutOfBoard(
+export function checkViasOffBoard(
   circuitJson: AnyCircuitElement[],
 ): PcbPlacementError[] {
   const board = circuitJson.find((el) => el.type === "pcb_board") as PcbBoard
@@ -32,10 +33,10 @@ export function checkViasOutOfBoard(
     const viaMaxY = via.y + viaRadius
 
     if (
-      viaMinX < boardMinX ||
-      viaMaxX > boardMaxX ||
-      viaMinY < boardMinY ||
-      viaMaxY > boardMaxY
+      viaMinX < boardMinX + DEFAULT_VIA_BOARD_MARGIN ||
+      viaMaxX > boardMaxX - DEFAULT_VIA_BOARD_MARGIN ||
+      viaMinY < boardMinY + DEFAULT_VIA_BOARD_MARGIN ||
+      viaMaxY > boardMaxY - DEFAULT_VIA_BOARD_MARGIN
     ) {
       const viaName = getReadableNameForElement(circuitJson, via.pcb_via_id)
       errors.push({

lib/check-vias-out-of-board/checkViasOutOfBoard.ts

@@ -1,5 +1,6 @@
 export const DEFAULT_TRACE_MARGIN = 0.1
 export const DEFAULT_TRACE_THICKNESS = 0.15
 export const DEFAULT_VIA_DIAMETER = 0.6
+export const DEFAULT_VIA_BOARD_MARGIN = 0.3
 
 export const EPSILON = 0.005

lib/drc-defaults.ts

@@ -1,6 +1,6 @@
 import { test, expect } from "bun:test"
 import type { AnyCircuitElement, PcbPlacementError } from "circuit-json"
-import { checkViasOutOfBoard } from "lib/check-pcb-components-out-of-board/checkViasOutOfBoard"
+import { checkViasOffBoard } from "lib/check-pcb-components-out-of-board/checkViasOffBoard"
 
 test("no board, should return no errors", () => {
   const soup: AnyCircuitElement[] = [
@@ -14,7 +14,7 @@ test("no board, should return no errors", () => {
       layers: ["top", "bottom"],
     },
   ]
-  const errors = checkViasOutOfBoard(soup)
+  const errors = checkViasOffBoard(soup)
   expect(errors).toEqual([])
 })
 
@@ -30,7 +30,7 @@ test("no vias, should return no errors", () => {
       thickness: 1.2,
     },
   ]
-  const errors = checkViasOutOfBoard(soup)
+  const errors = checkViasOffBoard(soup)
   expect(errors).toEqual([])
 })
 
@@ -55,7 +55,7 @@ test("via completely inside board, should return no errors", () => {
       layers: ["top", "bottom"],
     },
   ]
-  const errors = checkViasOutOfBoard(soup)
+  const errors = checkViasOffBoard(soup)
   expect(errors).toEqual([])
 })
 
@@ -80,7 +80,7 @@ test("via partially outside board (crossing boundary), should return an error",
       layers: ["top", "bottom"],
     },
   ]
-  const errors = checkViasOutOfBoard(soup)
+  const errors = checkViasOffBoard(soup)
   expect(errors).toHaveLength(1)
   expect(errors[0].message).toContain(
     "Via pcb_via[#via_partially_out] is outside or crossing the board boundary",
@@ -111,7 +111,7 @@ test("via completely outside board, should return an error", () => {
       layers: ["top", "bottom"],
     },
   ]
-  const errors = checkViasOutOfBoard(soup)
+  const errors = checkViasOffBoard(soup)
   expect(errors).toHaveLength(1)
   expect(errors[0].message).toContain(
     "Via pcb_via[#via_completely_out] is outside or crossing the board boundary",
@@ -163,7 +163,7 @@ test("multiple vias, some in, some out", () => {
       layers: ["top", "bottom"],
     },
   ]
-  const errors = checkViasOutOfBoard(soup)
+  const errors = checkViasOffBoard(soup)
   expect(errors).toHaveLength(2)
   const errorMessages = errors.map((e) => e.message)
   expect(errorMessages).toContain(