Skip to content

Commit 6dce5aa

Browse files
robherringLorenzo Pieralisi
authored andcommitted
PCI: xgene: Use inbound resources for setup
Now that the helpers provide the inbound resources in the host bridge 'dma_ranges' resource list, convert the Xgene host bridge to use the resource list to setup the inbound addresses. Signed-off-by: Rob Herring <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Reviewed-by: Andrew Murray <[email protected]> Cc: Toan Le <[email protected]> Cc: Lorenzo Pieralisi <[email protected]> Cc: Bjorn Helgaas <[email protected]>
1 parent 070d7d7 commit 6dce5aa

File tree

1 file changed

+11
-22
lines changed

1 file changed

+11
-22
lines changed

drivers/pci/controller/pci-xgene.c

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -481,27 +481,28 @@ static int xgene_pcie_select_ib_reg(u8 *ib_reg_mask, u64 size)
481481
}
482482

483483
static void xgene_pcie_setup_ib_reg(struct xgene_pcie_port *port,
484-
struct of_pci_range *range, u8 *ib_reg_mask)
484+
struct resource_entry *entry,
485+
u8 *ib_reg_mask)
485486
{
486487
void __iomem *cfg_base = port->cfg_base;
487488
struct device *dev = port->dev;
488489
void *bar_addr;
489490
u32 pim_reg;
490-
u64 cpu_addr = range->cpu_addr;
491-
u64 pci_addr = range->pci_addr;
492-
u64 size = range->size;
491+
u64 cpu_addr = entry->res->start;
492+
u64 pci_addr = cpu_addr - entry->offset;
493+
u64 size = resource_size(entry->res);
493494
u64 mask = ~(size - 1) | EN_REG;
494495
u32 flags = PCI_BASE_ADDRESS_MEM_TYPE_64;
495496
u32 bar_low;
496497
int region;
497498

498-
region = xgene_pcie_select_ib_reg(ib_reg_mask, range->size);
499+
region = xgene_pcie_select_ib_reg(ib_reg_mask, size);
499500
if (region < 0) {
500501
dev_warn(dev, "invalid pcie dma-range config\n");
501502
return;
502503
}
503504

504-
if (range->flags & IORESOURCE_PREFETCH)
505+
if (entry->res->flags & IORESOURCE_PREFETCH)
505506
flags |= PCI_BASE_ADDRESS_MEM_PREFETCH;
506507

507508
bar_low = pcie_bar_low_val((u32)cpu_addr, flags);
@@ -532,25 +533,13 @@ static void xgene_pcie_setup_ib_reg(struct xgene_pcie_port *port,
532533

533534
static int xgene_pcie_parse_map_dma_ranges(struct xgene_pcie_port *port)
534535
{
535-
struct device_node *np = port->node;
536-
struct of_pci_range range;
537-
struct of_pci_range_parser parser;
538-
struct device *dev = port->dev;
536+
struct pci_host_bridge *bridge = pci_host_bridge_from_priv(port);
537+
struct resource_entry *entry;
539538
u8 ib_reg_mask = 0;
540539

541-
if (of_pci_dma_range_parser_init(&parser, np)) {
542-
dev_err(dev, "missing dma-ranges property\n");
543-
return -EINVAL;
544-
}
545-
546-
/* Get the dma-ranges from DT */
547-
for_each_of_pci_range(&parser, &range) {
548-
u64 end = range.cpu_addr + range.size - 1;
540+
resource_list_for_each_entry(entry, &bridge->dma_ranges)
541+
xgene_pcie_setup_ib_reg(port, entry, &ib_reg_mask);
549542

550-
dev_dbg(dev, "0x%08x 0x%016llx..0x%016llx -> 0x%016llx\n",
551-
range.flags, range.cpu_addr, end, range.pci_addr);
552-
xgene_pcie_setup_ib_reg(port, &range, &ib_reg_mask);
553-
}
554543
return 0;
555544
}
556545

0 commit comments

Comments
 (0)