Skip to content

Commit 74891cb

Browse files
Examples: minor accessibility improvements (#40620)
- no need for `role="document"` on modals (was removed from Bootstrap a while ago) - use `type="email"` for email input - add aria-labels for previous month and next month buttons on date picker demo Co-authored-by: Julien Déramond <[email protected]>
1 parent 7f8fed4 commit 74891cb

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

site/content/docs/5.3/examples/dropdowns/index.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@
208208
<div class="d-grid gap-1">
209209
<div class="cal">
210210
<div class="cal-month">
211-
<button class="btn cal-btn" type="button">
211+
<button class="btn cal-btn" type="button" aria-label="previous month">
212212
<svg class="bi" width="16" height="16"><use xlink:href="#arrow-left-short"/></svg>
213213
</button>
214214
<strong class="cal-month-name">June</strong>
@@ -226,7 +226,7 @@
226226
<option value="November">November</option>
227227
<option value="December">December</option>
228228
</select>
229-
<button class="btn cal-btn" type="button">
229+
<button class="btn cal-btn" type="button" aria-label="next month">
230230
<svg class="bi" width="16" height="16"><use xlink:href="#arrow-right-short"/></svg>
231231
</button>
232232
</div>
@@ -287,7 +287,7 @@
287287
<div class="d-grid gap-1">
288288
<div class="cal">
289289
<div class="cal-month">
290-
<button class="btn cal-btn" type="button">
290+
<button class="btn cal-btn" type="button" aria-label="previous month">
291291
<svg class="bi" width="16" height="16"><use xlink:href="#arrow-left-short"/></svg>
292292
</button>
293293
<strong class="cal-month-name">June</strong>
@@ -305,7 +305,7 @@
305305
<option value="November">November</option>
306306
<option value="December">December</option>
307307
</select>
308-
<button class="btn cal-btn" type="button">
308+
<button class="btn cal-btn" type="button" aria-label="next month">
309309
<svg class="bi" width="16" height="16"><use xlink:href="#arrow-right-short"/></svg>
310310
</button>
311311
</div>

site/content/docs/5.3/examples/footers/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ <h5>Subscribe to our newsletter</h5>
167167
<p>Monthly digest of what's new and exciting from us.</p>
168168
<div class="d-flex flex-column flex-sm-row w-100 gap-2">
169169
<label for="newsletter1" class="visually-hidden">Email address</label>
170-
<input id="newsletter1" type="text" class="form-control" placeholder="Email address">
170+
<input id="newsletter1" type="email" class="form-control" placeholder="Email address">
171171
<button class="btn btn-primary" type="button">Subscribe</button>
172172
</div>
173173
</form>

site/content/docs/5.3/examples/modals/index.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
</svg>
3535

3636
<div class="modal modal-sheet position-static d-block bg-body-secondary p-4 py-md-5" tabindex="-1" role="dialog" id="modalSheet">
37-
<div class="modal-dialog" role="document">
37+
<div class="modal-dialog">
3838
<div class="modal-content rounded-4 shadow">
3939
<div class="modal-header border-bottom-0">
4040
<h1 class="modal-title fs-5">Modal title</h1>
@@ -54,7 +54,7 @@ <h1 class="modal-title fs-5">Modal title</h1>
5454
<div class="b-example-divider"></div>
5555

5656
<div class="modal modal-sheet position-static d-block bg-body-secondary p-4 py-md-5" tabindex="-1" role="dialog" id="modalChoice">
57-
<div class="modal-dialog" role="document">
57+
<div class="modal-dialog">
5858
<div class="modal-content rounded-3 shadow">
5959
<div class="modal-body p-4 text-center">
6060
<h5 class="mb-0">Enable this setting?</h5>
@@ -71,7 +71,7 @@ <h5 class="mb-0">Enable this setting?</h5>
7171
<div class="b-example-divider"></div>
7272

7373
<div class="modal modal-sheet position-static d-block bg-body-secondary p-4 py-md-5" tabindex="-1" role="dialog" id="modalTour">
74-
<div class="modal-dialog" role="document">
74+
<div class="modal-dialog">
7575
<div class="modal-content rounded-4 shadow">
7676
<div class="modal-body p-5">
7777
<h2 class="fw-bold mb-0">What's new</h2>
@@ -108,7 +108,7 @@ <h5 class="mb-0">Video embeds</h5>
108108
<div class="b-example-divider"></div>
109109

110110
<div class="modal modal-sheet position-static d-block bg-body-secondary p-4 py-md-5" tabindex="-1" role="dialog" id="modalSignin">
111-
<div class="modal-dialog" role="document">
111+
<div class="modal-dialog">
112112
<div class="modal-content rounded-4 shadow">
113113
<div class="modal-header p-5 pb-4 border-bottom-0">
114114
<h1 class="fw-bold mb-0 fs-2">Sign up for free</h1>

0 commit comments

Comments
 (0)