You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
**Summary**
Updating to 1.13.6 which is the version used internally in Facebook's codebase, so that there are no conflicts in how prettier dictates formatting. Right now, we're seeing an issue where 1.13.6 dictates different formatting for nested ternary operators & this broke the Travis CI in facebookarchive/draft-js@0cb80b7...fbc8a0c#diff-4e6b8232e09a07f699eebad1949b3ba3L118
Looks like the earlier breakage due to prettier version upgrade reported in facebookarchive#1562 is now not an issue with a much higher version :)
**Test Plan**
Before fix (breakage in Travis at https://travis-ci.org/facebook/draft-js/jobs/424170309):
```
$ eslint .
/home/travis/build/facebook/draft-js/src/model/immutable/BlockTree.js
30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars
/home/travis/build/facebook/draft-js/src/model/transaction/moveBlockInContentState.js
119:33 error Replace `⏎··········?·targetBlockIndex·-·1⏎·········` with `·?·targetBlockIndex·-·1` prettier/prettier
✖ 2 problems (1 error, 1 warning)
1 error, 0 warnings potentially fixable with the `--fix` option.
```
After fix:
```
> yarn run lint
Using globally installed version of Yarn
yarn run v1.5.1
$ eslint .
/Users/niveditc/draft-js/src/model/immutable/BlockTree.js
30:7 warning 'FINGERPRINT_DELIMITER' is assigned a value but never used. Allowed unused vars must match /^_/ no-unused-vars
✖ 1 problem (0 errors, 1 warning)
✨ Done in 8.50s.
```
(will be fixing the warning separately, that's been ongoing for a while).
Pull Request resolved: facebookarchive#1854
Reviewed By: elboman
Differential Revision: D9636114
Pulled By: elboman
fbshipit-source-id: 037c692554976b4626e27d3ebc0ccf95922bfb38
0 commit comments