Skip to content

hint.quick is does not work when go to previous tab. #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
himanoa opened this issue Jan 15, 2024 · 2 comments
Open
2 tasks done

hint.quick is does not work when go to previous tab. #317

himanoa opened this issue Jan 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@himanoa
Copy link

himanoa commented Jan 15, 2024

The issue is already reported or known issue?

  • I have searched the existing issues on github
  • I am using the latest version

Current behavior

It seems that hint.quick sometimes does not work when returning to the previous page

Even in this state, hint.open and other key bindings could be used.

Expected behavior

hint.quick is worked when returning to the previous page

Steps to reproduce

  1. Open page to https://google.com/search?q=google
  2. Press key f and click google link
  3. Press key H
  4. Press key f

This step may not reproduce the problem,

but you can reproduce it by repeating it.

vimmatic

Environment

  • OS: Windows 10 (64 bit)
  • Browser: Firefox 121.0.1 (64bit)
  • Vimmatic version :0.6.0
@himanoa himanoa added the bug Something isn't working label Jan 15, 2024
@himanoa
Copy link
Author

himanoa commented Jan 15, 2024

I noticed display large amount of error logs in devtools when hint.quick does not worked.

unexpected message format: SyntaxError: JSON.parse: unexpected character at line 1 column 2 of the JSON data
    listen WindowMessageListener.ts:43
    listen WindowMessageListener.ts:30
    init Application.ts:24
    Li index.ts:10
    Li index.ts:15
    <anonymous> index.ts:22
    t Bootstrap.ts:14
    waitForReady Bootstrap.ts:11
    <anonymous> index.ts:22
    <anonymous> index.ts:22
[WindowMessageListener.ts:46:16](moz-extension://3c5a0012-9372-4467-be65-c7abb46eb62c/src/content/messaging/WindowMessageListener.ts)
unexpected message format: SyntaxError: JSON.parse: unexpected character at line 1 column 2 of the JSON data
    listen WindowMessageListener.ts:43
    listen WindowMessageListener.ts:30
    init Application.ts:24
    Li index.ts:10
    Li index.ts:15
    <anonymous> index.ts:22
    t Bootstrap.ts:14
    waitForReady Bootstrap.ts:11
    <anonymous> index.ts:22
    <anonymous> index.ts:22
[WindowMessageListener.ts:46:16](moz-extension://3c5a0012-9372-4467-be65-c7abb46eb62c/src/content/messaging/WindowMessageListener.ts)
unexpected message format: SyntaxError: JSON.parse: unexpected character at line 1 column 2 of the JSON data
    listen WindowMessageListener.ts:43
    listen WindowMessageListener.ts:30
    init Application.ts:24
    Li index.ts:10
    Li index.ts:15
    <anonymous> index.ts:22
    t Bootstrap.ts:14
    waitForReady Bootstrap.ts:11
    <anonymous> index.ts:22
    <anonymous> index.ts:22
[WindowMessageListener.ts:46:16](moz-extension://3c5a0012-9372-4467-be65-c7abb46eb62c/src/content/messaging/WindowMessageListener.ts)

​```

@himanoa
Copy link
Author

himanoa commented Jan 16, 2024

As I debugged, I found that when hint.quick is not running, frameRepository#getFrameIds seems to return undefined.

if (typeof frameIds === "undefined") {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant