Skip to content

random undefined message causes synckit to throw an error #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dylang opened this issue Sep 5, 2024 · 2 comments · Fixed by prettier/eslint-plugin-prettier#715
Open

random undefined message causes synckit to throw an error #185

dylang opened this issue Sep 5, 2024 · 2 comments · Fixed by prettier/eslint-plugin-prettier#715

Comments

@dylang
Copy link

dylang commented Sep 5, 2024

It looks like we are assuming all recieved messages are objects with a message property: https://github.com/un-ts/synckit/blob/main/src/index.ts#L548

However, sometimes, randomly, only in CI, it seems to receive undefined, which synckit doesn't handle, so it throws an error.

Related: prettier/eslint-plugin-prettier#671
@JounQin
Copy link
Member

JounQin commented Mar 19, 2025

Without correct reproduction, it's hard to say what is root issue, and are you still having this issue at this time?

@JounQin JounQin mentioned this issue Mar 24, 2025
Merged
@JounQin
Copy link
Member

JounQin commented Apr 1, 2025

We have a persistent reproduction now #217

@JounQin JounQin reopened this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: hourcekeeping, bump all (dev) deps prettier/eslint-plugin-prettier
2 participants
@dylang @JounQin