Skip to content

Feature: support REDIRECT in the standalone client implementation #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks
rueian opened this issue Mar 31, 2025 · 2 comments
Open
2 tasks

Feature: support REDIRECT in the standalone client implementation #39

rueian opened this issue Mar 31, 2025 · 2 comments
Assignees
@SoulPancake
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rueian
Copy link
Collaborator

rueian commented Mar 31, 2025

The standalone Valkey 8 server can respond with REDIRECT messages when a client enables CLIENT CAPA redirect, therefore, our standalone client implementation should be able to follow them.

Related to valkey-io/valkey-doc#164 and https://valkey.io/commands/client-capa/

TODO:

  • Add EnableRedirect to the StandaloneOption struct and send CLIENT CAPA redirect command when making connections.
  • Check if a response is a REDIRECT message and do the redirection in the standalone client implementation.
@rueian rueian added enhancement New feature or request good first issue Good for newcomers labels Mar 31, 2025
@SoulPancake
Copy link
Contributor

Can you assign this to me? @rueian

@rueian
Copy link
Collaborator Author

rueian commented Apr 4, 2025

sure

@rueian rueian assigned rueian and SoulPancake and unassigned rueian Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoulPancake SoulPancake

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rueian @SoulPancake