Skip to content

Commit ddca1c4

Browse files
madolsonzuiderkwast
authored andcommitted
Remove readability refactor for failover auth to fix clang warning (#1481)
As part of #1463, I made a small refactor between the PR and the daily test I submitted to try to improve readability by adding a function to abstract the extraction of the message types. However, that change apparently caused GCC to throw another warning, so reverting the abstraction on just one line. Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Jacob Murphy <[email protected]>
1 parent a3a137b commit ddca1c4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cluster_legacy.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -4289,7 +4289,7 @@ void clusterRequestFailoverAuth(void) {
42894289
/* If this is a manual failover, set the CLUSTERMSG_FLAG0_FORCEACK bit
42904290
* in the header to communicate the nodes receiving the message that
42914291
* they should authorized the failover even if the primary is working. */
4292-
if (server.cluster->mf_end) getMessageFromSendBlock(msgblock)->mflags[0] |= CLUSTERMSG_FLAG0_FORCEACK;
4292+
if (server.cluster->mf_end) msgblock->data[0].msg.mflags[0] |= CLUSTERMSG_FLAG0_FORCEACK;
42934293
clusterBroadcastMessage(msgblock);
42944294
clusterMsgSendBlockDecrRefCount(msgblock);
42954295
}

0 commit comments

Comments
 (0)