Skip to content

Large overhead for log p computation in DOMIAS #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JimAchterbergLUMC opened this issue Mar 30, 2025 · 0 comments
Open

Large overhead for log p computation in DOMIAS #329

JimAchterbergLUMC opened this issue Mar 30, 2025 · 0 comments

Comments

@JimAchterbergLUMC
Copy link

Description

When evaluating log probabilities for the DOMIAS metric, gradient computation is not disabled, causing massive overhead when the test set is large.

During training, log probabilities are computed in batches. However, during inference this is not the case, causing massive overhead since gradients are still being computed.

How to Reproduce

  1. Go to 'synthcity/metrics/eval_privacy.py', line 594. Here we see that log probabilities are computed for the entire test set at once, without disabling gradients. When the test set is made to be reasonably large, this (unnecessarily) takes up a large amount of memory.

Expected Behavior

Disable gradient computation during inference when computing log probabilities for DOMIAS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant