Skip to content

Public key comparison formatting issue. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vaultec81 opened this issue Nov 2, 2019 · 0 comments
Open

Public key comparison formatting issue. #2

vaultec81 opened this issue Nov 2, 2019 · 0 comments
Assignees
@vaultec81
Labels
bug Something isn't working

Comments

@vaultec81
Copy link
Owner

Currently in multiple areas of the code public keys are compared with a value comparison (===). However, public keys can be shortened, or formatted differently which can throw off comparison. Instead the public key will be decoding first, then compared.
@vaultec81 vaultec81 added the bug Something isn't working label Nov 2, 2019
@vaultec81 vaultec81 self-assigned this Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaultec81 vaultec81

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vaultec81