Skip to content

Ivy version range [1.0,2.0] is not satisfied by 1.0 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcelBochtler opened this issue Jul 2, 2022 · 1 comment
Open

Ivy version range [1.0,2.0] is not satisfied by 1.0 #67

MarcelBochtler opened this issue Jul 2, 2022 · 1 comment

Comments

@MarcelBochtler
Copy link

Using

Requirement.buildIvy("[1.0,2.0]").isSatisfiedBy(Semver("1.0", Semver.SemverType.LOOSE))

in version 3.1.0 retuns false, but according to the ivy version-matchers specification, it should be true.

This is caused by this check:

return version.isGreaterThan(this.version) || version.isEquivalentTo(this.version);

Where in the right-hand side of the ||, "1.0".isEquivalentTo("1.0.0") is checked, which then internally calls "1.0".isEqualTo("1.0.0").

This issue might be related to #59.

@piotrooo
Copy link

@MarcelBochtler if you are still interesting, I've made copy of this lib and fix bug reported by you. Look for version 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants