Skip to content

Commit 27d146f

Browse files
committed
Add extensive hydration error test suite for Pages router
Pages router will support both React 18 and 19 which has significant changes for hydration errors. The existing acceptance tests only cover App router which runs exclusive on React 19. Ideally this would be a single test suite that just forks on the assertion. However, there are a lot of differences between App router and Pages router and putting that into a single file takes more time. The goal here is to not regress any further with Pages router when extending support to 18. Once RC2 landed, I'll merge these test suites.
1 parent d9fa5c9 commit 27d146f

File tree

4 files changed

+814
-39
lines changed

4 files changed

+814
-39
lines changed

test/development/acceptance-app/hydration-error.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { getRedboxTotalErrorCount } from 'next-test-utils'
77

88
// https://github.com/facebook/react/blob/main/packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js used as a reference
99

10-
describe('Error overlay for hydration errors', () => {
10+
describe('Error overlay for hydration errors in App router', () => {
1111
const { next, isTurbopack } = nextTestSetup({
1212
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
1313
skipStart: true,

0 commit comments

Comments
 (0)