Skip to content

Commit fbd6174

Browse files
committed
Ensure compiled React is not treated as an external
`next/dist/compiled/react-dom` can never appear in a require call i.e. be treated as an external because these modules don't import from vendored react-dom but installed react-dom
1 parent fd04461 commit fbd6174

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/next/src/build/create-compiler-aliases.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,9 @@ export function createRSCAliases(
259259
'react-dom/static$': `next/dist/compiled/react-dom-experimental/static`,
260260
'react-dom/static.edge$': `next/dist/compiled/react-dom-experimental/static.edge`,
261261
'react-dom/static.browser$': `next/dist/compiled/react-dom-experimental/static.browser`,
262-
// optimizations to ignore the legacy build of react-dom/server in `server.browser` build
263-
'react-dom/server.edge$': `next/dist/build/webpack/alias/react-dom-server-edge${bundledReactChannel}.js`,
264-
'react-dom/server.browser$': `next/dist/build/webpack/alias/react-dom-server-browser${bundledReactChannel}.js`,
262+
// TODO: restore optimizations to ignore the legacy build of react-dom/server in `server.browser` build
263+
'react-dom/server.edge$': `next/dist/compiled/react-dom${bundledReactChannel}/server.edge`,
264+
'react-dom/server.browser$': `next/dist/compiled/react-dom${bundledReactChannel}/server.browser`,
265265
// react-server-dom-webpack alias
266266
'react-server-dom-webpack/client$': `next/dist/compiled/react-server-dom-webpack${bundledReactChannel}/client`,
267267
'react-server-dom-webpack/client.edge$': `next/dist/compiled/react-server-dom-webpack${bundledReactChannel}/client.edge`,

0 commit comments

Comments
 (0)