Resolve fail test #10807

issidorov · weirdan · commit fe42e8821d6f · 2024-03-11T20:09:30.000+01:00
Resolved problem:
```
Psalm\Tests\AssertAnnotationTest::testAssertsAllongCallStaticMethodWork
Psalm\Exception\CodeException: LessSpecificReturnStatement
The type 'string' is more general than the declared return type 'non-empty-string' for returnNonEmpty
```
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticMethod/AtomicStaticCallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticMethod/AtomicStaticCallAnalyzer.php
@@ -789,7 +789,7 @@ private static function handleNamedCall(
             }
         }
 
-        if (!$callstatic_method_exists || $class_storage->hasSealedMethods($config)) {
+        if ($naive_method_exists || !$callstatic_method_exists || $class_storage->hasSealedMethods($config)) {
             $does_method_exist = MethodAnalyzer::checkMethodExists(
                 $codebase,
                 $method_id,

Original file line number	Diff line number	Diff line change
`@@ -789,7 +789,7 @@ private static function handleNamedCall(`
`789`	`789`	`}`
`790`	`790`	`}`
`791`	`791`
`792`		`- if (!$callstatic_method_exists \|\| $class_storage->hasSealedMethods($config)) {`
	`792`	`+ if ($naive_method_exists \|\| !$callstatic_method_exists \|\| $class_storage->hasSealedMethods($config)) {`
`793`	`793`	`$does_method_exist = MethodAnalyzer::checkMethodExists(`
`794`	`794`	`$codebase,`
`795`	`795`	`$method_id,`