Skip to content

Commit 27f691b

Browse files
authored
refactor: make internal invoke event to use the same interface with handleInvoke (#18902)
1 parent 30f256e commit 27f691b

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

packages/vite/src/node/server/hmr.ts

+4-10
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ export const normalizeHotChannel = (
193193
) => {
194194
if (!invokeHandlers) {
195195
return {
196-
e: {
196+
error: {
197197
name: 'TransportError',
198198
message: 'invokeHandlers is not set',
199199
stack: new Error().stack,
@@ -207,10 +207,10 @@ export const normalizeHotChannel = (
207207
const invokeHandler = invokeHandlers[name]
208208
// @ts-expect-error `invokeHandler` is `InvokeMethods[T]`, so passing the args is fine
209209
const result = await invokeHandler(...args)
210-
return { r: result }
210+
return { result }
211211
} catch (error) {
212212
return {
213-
e: {
213+
error: {
214214
name: error.name,
215215
message: error.message,
216216
stack: error.stack,
@@ -301,13 +301,7 @@ export const normalizeHotChannel = (
301301
}
302302
channel.on?.('vite:invoke', listenerForInvokeHandler)
303303
},
304-
handleInvoke: async (payload) => {
305-
const data = await handleInvoke(payload)
306-
if (data.e) {
307-
return { error: data.e }
308-
}
309-
return { result: data.r }
310-
},
304+
handleInvoke,
311305
send: (...args: any[]) => {
312306
let payload: HotPayload
313307
if (typeof args[0] === 'string') {

packages/vite/src/shared/invokeMethods.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ export type InvokeResponseData<
7272
/** 'response' is for responses without an id */
7373
id: 'response' | `response:${string}`
7474
data:
75-
| { r: Awaited<ReturnType<InvokeMethods[T]>>; e?: undefined }
76-
| { r?: undefined; e: any }
75+
| { result: Awaited<ReturnType<InvokeMethods[T]>>; error?: undefined }
76+
| { result?: undefined; error: any }
7777
}
7878

7979
export type InvokeMethods = {

packages/vite/src/shared/moduleRunnerTransport.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ const createInvokeableTransport = (
9696

9797
rpcPromises.delete(invokeId)
9898

99-
const { e, r } = data.data
100-
if (e) {
101-
promise.reject(e)
99+
const { error, result } = data.data
100+
if (error) {
101+
promise.reject(error)
102102
} else {
103-
promise.resolve(r)
103+
promise.resolve(result)
104104
}
105105
return
106106
}

0 commit comments

Comments
 (0)