Skip to content

Commit fc89057

Browse files
authored
fix: node v18 support (#7812)
1 parent ba43c29 commit fc89057

File tree

5 files changed

+57
-44
lines changed

5 files changed

+57
-44
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,17 @@ jobs:
2727
strategy:
2828
matrix:
2929
os: [ubuntu-latest]
30-
node_version: [12, 14, 16, 17]
30+
node_version: [12, 14, 16, 17, 18]
3131
include:
3232
- os: macos-latest
3333
node_version: 16
34+
- os: macos-latest
35+
node_version: 18
3436
- os: windows-latest
3537
node_version: 16
38+
# Maybe bug with jest on windows and node-v18
39+
# - os: windows-latest
40+
# node_version: 18
3641
fail-fast: false
3742

3843
name: "Build&Test: node-${{ matrix.node_version }}, ${{ matrix.os }}"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"@microsoft/api-extractor": "^7.22.2",
3838
"@types/fs-extra": "^9.0.13",
3939
"@types/jest": "^27.4.1",
40-
"@types/node": "^16.11.27",
40+
"@types/node": "^17.0.25",
4141
"@types/prompts": "^2.0.14",
4242
"@types/semver": "^7.3.9",
4343
"@typescript-eslint/eslint-plugin": "^5.20.0",

packages/vite/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"@types/less": "^3.0.3",
7272
"@types/micromatch": "^4.0.2",
7373
"@types/mime": "^2.0.3",
74-
"@types/node": "^16.11.27",
74+
"@types/node": "^17.0.25",
7575
"@types/resolve": "^1.20.1",
7676
"@types/sass": "~1.43.1",
7777
"@types/stylus": "^0.48.37",

packages/vite/src/node/logger.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,15 @@ function printServerUrls(
190190
} else {
191191
Object.values(os.networkInterfaces())
192192
.flatMap((nInterface) => nInterface ?? [])
193-
.filter((detail) => detail && detail.address && detail.family === 'IPv4')
193+
.filter(
194+
(detail) =>
195+
detail &&
196+
detail.address &&
197+
// Node < v18
198+
((typeof detail.family === 'string' && detail.family === 'IPv4') ||
199+
// Node >= v18
200+
(typeof detail.family === 'number' && detail.family === 4))
201+
)
194202
.map((detail) => {
195203
const type = detail.address.includes('127.0.0.1')
196204
? 'Local: '

pnpm-lock.yaml

Lines changed: 40 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)