Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetLocal should not be called during execution #169

Open
andrewyunt opened this issue Jul 21, 2022 · 1 comment
Open

SetLocal should not be called during execution #169

andrewyunt opened this issue Jul 21, 2022 · 1 comment

Comments

@andrewyunt
Copy link
Contributor

andrewyunt commented Jul 21, 2022

Function is called in testingutil.go and funcs.go in Sonolark

https://pkg.go.dev/go.starlark.net/starlark#Thread.SetLocal

@johnSchnake
Copy link
Contributor

google/starlark-go#252 (comment) is an example of embedding the go context into the thread local storage before the run but still having the potential for it to change (ie obviously this is useful only because the context may be marked as stopped/cancelled elsewhere and that being reflected in this method).

Not quite the same as my expected workaround of embedding the context so we can add data into its databag, but similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants