Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifact-manager needs to be better structured #305

Open
Michaelpalacce opened this issue Jul 11, 2024 · 3 comments
Open

artifact-manager needs to be better structured #305

Michaelpalacce opened this issue Jul 11, 2024 · 3 comments
Assignees
Labels
area/artifact-manager Relates to the `artifact-manager` maven module kind/refactor Refactoring of existing features lang/java Related to Java Code triage/accepted The issue was accepted and will be done

Comments

@Michaelpalacce
Copy link
Collaborator

Michaelpalacce commented Jul 11, 2024

Description

The structure of artifact-manager needs to be refactored to be better structured. Currently there is almost no structure and classes are added to random places.

Examples

store folder has filters, I'd assume that different stores should be put here
Pasted image 20240704184928

Store classes not under store folder
Pasted image 20240704184959

Special structure for vRLI under rest/client, but no other clients present
image

Misplaced models
image

Proposal

image
  1. Ignore the fact that it says artifact-new this is just a placeholder, the same artifact folder should be used.
  2. Each different archetype is put in a separate folder
  3. common folder contains any common components that can be used by the other archetypes
  4. Inside the archetype folders, if the API is versioned, then we need to have a clear distinction for that too... this is only valid for major API changes, example would be vRLI v1 and v2 apis.
    • Example:
    • image
@Michaelpalacce Michaelpalacce added lang/java Related to Java Code area/artifact-manager Relates to the `artifact-manager` maven module triage/needed Needs to be discussed by project maintainers kind/refactor Refactoring of existing features labels Jul 11, 2024
@akantchev akantchev self-assigned this Jul 11, 2024
@akantchev akantchev added this to the 3.0.0 milestone Jul 11, 2024
@Michaelpalacce
Copy link
Collaborator Author

Michaelpalacce commented Jul 15, 2024

@akantchev this will not be a breaking change, correct? If so do we need to have the 3.0.0 milestone?

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 15, 2024
@Michaelpalacce Michaelpalacce added triage/accepted The issue was accepted and will be done and removed triage/needed Needs to be discussed by project maintainers Stale labels Aug 16, 2024
Michaelpalacce added a commit that referenced this issue Jan 14, 2025
…on components (#581)

* refactor: Moved `ConfigurationVraNg` to new place
Signed-off-by: Stefan Genov <[email protected]>

* fix: `AbstractIacMojo` import for Configuration vrang
Signed-off-by: Stefan Genov <[email protected]>

* refactor: Moved models
Signed-off-by: Stefan Genov <[email protected]>

* refactor!: Moved VRANG Stores
Signed-off-by: Stefan Genov <[email protected]>

* refactor!: Moved the rest clients and helpers
Signed-off-by: Stefan Genov <[email protected]>

* refactor!: Moved tests to correct place
Signed-off-by: Stefan Genov <[email protected]>

* docs: Added a notice for aria migration
Signed-off-by: Stefan Genov <[email protected]>

* test: Fixed package
Signed-off-by: Stefan Genov <[email protected]>

* style(lint): A bunch of lint changes. Disabled VisibilityModifier rule
Signed-off-by: Stefan Genov <[email protected]>

* style(lint): Lint fixes
Signed-off-by: Stefan Genov <[email protected]>

* style(lint): Clearning out linting issues
Signed-off-by: Stefan Genov <[email protected]>

* fix: Imports
Signed-off-by: Stefan Genov <[email protected]>

* style(lint): Final lint issues
Signed-off-by: Stefan Genov <[email protected]>

* style(lint): Don't know what the linter wants at this point..

Signed-off-by: Stefan Genov <[email protected]>

* fix: build docs
Signed-off-by: Stefan Genov <[email protected]>

* fix: Docs build
Signed-off-by: Stefan Genov <[email protected]>

* docs: Added release docs
Signed-off-by: Stefan Genov <[email protected]>

* refator(aria-automation): Updated path
Signed-off-by: Stefan Genov <[email protected]>

* Update common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/IMPORTANT.md

Co-authored-by: Venelin Bakalov <[email protected]>
Signed-off-by: Stefan Genov <[email protected]>

* Update docs/versions/latest/Release.md

Co-authored-by: Venelin Bakalov <[email protected]>
Signed-off-by: Stefan Genov <[email protected]>

---------

Signed-off-by: Stefan Genov <[email protected]>
Signed-off-by: Stefan Genov <[email protected]>
Co-authored-by: Venelin Bakalov <[email protected]>
@VenelinBakalov VenelinBakalov modified the milestones: BTVA Next, 3.0.0 Jan 16, 2025
VenelinBakalov added a commit that referenced this issue Jan 17, 2025
…mponents

[artifact-manager,plugins,installer] (#305) Restructure Aria Operations components
@VenelinBakalov VenelinBakalov modified the milestones: 3.0.0, 4.0.0 Jan 30, 2025
@VenelinBakalov
Copy link
Collaborator

Partially implemented in milestone 3.x.x, will be finished in 4.x.x

@VenelinBakalov VenelinBakalov removed this from the 4.x.x milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifact-manager Relates to the `artifact-manager` maven module kind/refactor Refactoring of existing features lang/java Related to Java Code triage/accepted The issue was accepted and will be done
Projects
None yet
Development

No branches or pull requests

4 participants