Skip to content

Commit b5aceec

Browse files
fix: Add an SA for weave-trace deployment (#182)
1 parent 6a16c8d commit b5aceec

File tree

7 files changed

+43
-4
lines changed

7 files changed

+43
-4
lines changed

charts/operator-wandb/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: operator-wandb
33
description: A Helm chart for deploying W&B to Kubernetes
44
type: application
5-
version: 0.15.2
5+
version: 0.15.3
66
appVersion: 1.0.0
77
icon: https://wandb.ai/logo.svg
88

charts/operator-wandb/charts/weave-trace/templates/deployment.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ spec:
142142

143143
resources:
144144
{{- toYaml .Values.resources | nindent 12 }}
145+
serviceAccountName: {{ include "weaveTrace.serviceAccountName" . }}
145146
---
146147
apiVersion: autoscaling/v2
147148
kind: HorizontalPodAutoscaler
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{{- if .Values.serviceAccount.create -}}
2+
apiVersion: v1
3+
kind: ServiceAccount
4+
metadata:
5+
name: {{ include "weaveTrace.serviceAccountName" . }}
6+
labels:
7+
{{- include "wandb.commonLabels" . | nindent 4 }}
8+
{{- include "weaveTrace.commonLabels" . | nindent 4 }}
9+
{{- include "weaveTrace.labels" . | nindent 4 }}
10+
{{- if .Values.serviceAccount.labels -}}
11+
{{- toYaml .Values.serviceAccount.labels | nindent 4 }}
12+
{{- end }}
13+
annotations:
14+
{{- if .Values.serviceAccount.annotations -}}
15+
{{- toYaml .Values.serviceAccount.annotations | nindent 4 }}
16+
{{- end }}
17+
{{- end }}

charts/operator-wandb/charts/weave-trace/values.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ extraCors: []
1616
common:
1717
labels: {}
1818
deployment: {}
19-
serviceAccount: {}
19+
serviceAccount:
20+
create: true
21+
annotations: {}
2022
clusterRole: {}
2123

2224
service:

charts/operator-wandb/charts/weave/templates/deployment.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ spec:
107107

108108
resources:
109109
{{- toYaml .Values.cacheClear.resources | nindent 12 }}
110-
110+
serviceAccountName: {{ include "weave.serviceAccountName" . }}
111111
volumes:
112112
- name: cache
113113
emptyDir:
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{{- if .Values.serviceAccount.create -}}
2+
apiVersion: v1
3+
kind: ServiceAccount
4+
metadata:
5+
name: {{ include "weave.serviceAccountName" . }}
6+
labels:
7+
{{- include "wandb.commonLabels" . | nindent 4 }}
8+
{{- include "weave.commonLabels" . | nindent 4 }}
9+
{{- include "weave.labels" . | nindent 4 }}
10+
{{- if .Values.serviceAccount.labels -}}
11+
{{- toYaml .Values.serviceAccount.labels | nindent 4 }}
12+
{{- end }}
13+
annotations:
14+
{{- if .Values.serviceAccount.annotations -}}
15+
{{- toYaml .Values.serviceAccount.annotations | nindent 4 }}
16+
{{- end }}
17+
{{- end }}

charts/operator-wandb/charts/weave/values.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ extraCors: []
2525
common:
2626
labels: {}
2727
deployment: {}
28-
serviceAccount: {}
28+
serviceAccount:
29+
create: true
30+
annotations: {}
2931
clusterRole: {}
3032

3133
service:

0 commit comments

Comments
 (0)