Mechanical code improvements

Author: dizzzz

java/src/org/exist/mongodb/shared/ContentSerializer.java

@@ -224,9 +224,7 @@ static int addGridFSFileEntry(final MemTreeBuilder builder, final GridFSFile gfs
 
         List<String> aliases = gfsFile.getAliases();
         if (aliases != null) {
-            gfsFile.getAliases().stream().forEach((alias) -> {
-                addElementValue(builder, "alias", alias);
-            });
+            gfsFile.getAliases().stream().forEach((alias) -> addElementValue(builder, "alias", alias));
         }
 
         // mimetype

java/src/org/exist/mongodb/shared/MongodbClientStore.java

@@ -81,7 +81,7 @@ public  MongoClient validate(String mongodbClientId) throws XPathException {
         if (mongodbClientId == null || !isValid(mongodbClientId)) {
             try {
                 // introduce a delay
-                Thread.sleep(1000l);
+                Thread.sleep(1000L);
 
             } catch (InterruptedException ex) {
                 LOG.error(ex);

java/src/org/exist/mongodb/xquery/BSonModule.java

@@ -36,7 +36,7 @@ public class BSonModule extends AbstractInternalModule {
     public final static QName EXCEPTION_MESSAGE_QNAME
             = new QName("exception-message", BSonModule.NAMESPACE_URI, BSonModule.PREFIX);
 
-    public BSonModule(Map<String, List<? extends Object>> parameters) throws XPathException {
+    public BSonModule(Map<String, List<?>> parameters) throws XPathException {
         super(functions, parameters);
     }
 

java/src/org/exist/mongodb/xquery/GridfsModule.java

@@ -51,7 +51,7 @@ public class GridfsModule extends AbstractInternalModule {
     public final static QName EXCEPTION_MESSAGE_QNAME
             = new QName("exception-message", GridfsModule.NAMESPACE_URI, GridfsModule.PREFIX);
 
-    public GridfsModule(Map<String, List<? extends Object>> parameters) throws XPathException {
+    public GridfsModule(Map<String, List<?>> parameters) throws XPathException {
         super(functions, parameters);
     }
 

java/src/org/exist/mongodb/xquery/MongodbModule.java

@@ -124,7 +124,7 @@ public class MongodbModule extends AbstractInternalModule {
     public final static QName EXCEPTION_MESSAGE_QNAME
             = new QName("exception-message", MongodbModule.NAMESPACE_URI, MongodbModule.PREFIX);
 
-    public MongodbModule(Map<String, List<? extends Object>> parameters) throws XPathException {
+    public MongodbModule(Map<String, List<?>> parameters) throws XPathException {
         super(functions, parameters);
     }
 

java/src/org/exist/mongodb/xquery/gridfs/Get.java

@@ -178,10 +178,11 @@ Sequence get(GridFSDBFile gfsFile, boolean forceBinary) throws IOException, XPat
     }
 
     /**
-     * Parse an byte-array containing (compressed) XML data into an eXist-db
+     * Parse an byte-stream containing (compressed) XML data into an eXist-db
      * document.
      *
-     * @param data Byte array containing the XML data.
+     * @param xqueryContext Xquery context
+     * @param is Byte stream containing the XML data.
      * @return Sequence containing the XML as DocumentImpl
      *
      * @throws XPathException Something bad happened.
@@ -208,7 +209,7 @@ private Sequence processXML(XQueryContext xqueryContext, InputStream is) throws
             IOUtils.closeQuietly(is);
 
             if (validationReport.isValid()) {
-                content = (DocumentImpl) adapter.getDocument();
+                content = adapter.getDocument();
             } else {
                 String txt = String.format("Received document is not valid: %s", validationReport.toString());
                 LOG.debug(txt);

java/src/org/exist/mongodb/xquery/mongodb/client/ListDatabases.java

@@ -75,9 +75,7 @@ public Sequence eval(Sequence[] args, Sequence contextSequence) throws XPathExce
             MongoClient client = MongodbClientStore.getInstance().get(mongodbClientId);
 
             ValueSequence seq = new ValueSequence();
-            client.getDatabaseNames().stream().forEach((name) -> {
-                seq.add(new StringValue(name));
-            });
+            client.getDatabaseNames().stream().forEach((name) -> seq.add(new StringValue(name)));
             return seq;
 
         } catch (Throwable t) {

java/src/org/exist/mongodb/xquery/mongodb/client/ListMongdbClientIds.java

@@ -76,9 +76,7 @@ public Sequence eval(Sequence[] args, Sequence contextSequence) throws XPathExce
 
             ValueSequence valueSequence = new ValueSequence();
 
-            clientIds.stream().forEach((mongodbClientId) -> {
-                valueSequence.add(new StringValue(mongodbClientId));
-            });
+            clientIds.stream().forEach((mongodbClientId) -> valueSequence.add(new StringValue(mongodbClientId)));
 
             return valueSequence;
 

java/src/org/exist/mongodb/xquery/mongodb/db/ListCollections.java

@@ -84,9 +84,7 @@ public Sequence eval(Sequence[] args, Sequence contextSequence) throws XPathExce
             ValueSequence valueSequence = new ValueSequence();
 
             // Iterate over collection names
-            collectionNames.stream().forEach((collName) -> {
-                valueSequence.add(new StringValue(collName));
-            });
+            collectionNames.stream().forEach((collName) -> valueSequence.add(new StringValue(collName)));
 
             return valueSequence;