Skip to content

Commit 0e07e38

Browse files
authored
Add estimate parameter to update_virtual_pressure_source (#51194)
* Add estimate parameter to update_virtual_pressure_source spec PR: w3c/compute-pressure#305 This PR add own pressure estimate parameter to the update_virtual_pressure_source command as specified in https://w3c.github.io/compute-pressure/?experimental=1#update-virtual-pressure-source * Fix wrong update between sensor and pressure source There was a clear mistake in updating update_virtual_sensor instead of update_virtual_pressure_source in testdriver-extra.js * remove unnecessary default value * fix closing bracket * Fix wrong indent * remove default value for estimate
1 parent 922c1aa commit 0e07e38

File tree

6 files changed

+15
-11
lines changed

6 files changed

+15
-11
lines changed

Diff for: resources/testdriver.js

+7-4
Original file line numberDiff line numberDiff line change
@@ -1428,7 +1428,7 @@
14281428
* Causes a virtual pressure source to report a new reading.
14291429
*
14301430
* Matches the `Update virtual pressure source
1431-
* <https://w3c.github.io/compute-pressure/#update-virtual-pressure-source>`_
1431+
* <https://w3c.github.io/compute-pressure/?experimental=1#update-virtual-pressure-source>`_
14321432
* WebDriver command.
14331433
*
14341434
* @param {String} source_type - A `virtual pressure source type
@@ -1437,6 +1437,9 @@
14371437
* @param {String} sample - A `virtual pressure state
14381438
* <https://w3c.github.io/compute-pressure/#dom-pressurestate>`_
14391439
* such as "critical".
1440+
* @param {number} estimate - Optional, A `virtual own contribution estimate`
1441+
* <https://w3c.github.io/compute-pressure/?experimental=1#the-owncontributionestimate-attribute>`_
1442+
14401443
* @param {WindowProxy} [context=null] - Browsing context in which to
14411444
* run the call, or null for the
14421445
* current browsing context.
@@ -1447,8 +1450,8 @@
14471450
* virtual pressure source of the given type does not
14481451
* exist).
14491452
*/
1450-
update_virtual_pressure_source: function(source_type, sample, context=null) {
1451-
return window.test_driver_internal.update_virtual_pressure_source(source_type, sample, context);
1453+
update_virtual_pressure_source: function(source_type, sample, estimate, context=null) {
1454+
return window.test_driver_internal.update_virtual_pressure_source(source_type, sample, estimate, context);
14521455
},
14531456

14541457
/**
@@ -1723,7 +1726,7 @@
17231726
throw new Error("create_virtual_pressure_source() is not implemented by testdriver-vendor.js");
17241727
},
17251728

1726-
async update_virtual_pressure_source(source_type, sample, context=null) {
1729+
async update_virtual_pressure_source(source_type, sample, estimate, context=null) {
17271730
throw new Error("update_virtual_pressure_source() is not implemented by testdriver-vendor.js");
17281731
},
17291732

Diff for: tools/wptrunner/wptrunner/executors/actions.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,8 @@ def __init__(self, logger, protocol):
498498
def __call__(self, payload):
499499
source_type = payload["source_type"]
500500
sample = payload["sample"]
501-
return self.protocol.pressure.update_virtual_pressure_source(source_type, sample)
501+
estimate = payload["estimate"]
502+
return self.protocol.pressure.update_virtual_pressure_source(source_type, sample, estimate)
502503

503504
class RemoveVirtualPressureSourceAction:
504505
name = "remove_virtual_pressure_source"

Diff for: tools/wptrunner/wptrunner/executors/executormarionette.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ def setup(self):
721721
def create_virtual_pressure_source(self, source_type, metadata):
722722
raise NotImplementedError("create_virtual_pressure_source not yet implemented")
723723

724-
def update_virtual_pressure_source(self, source_type, sample):
724+
def update_virtual_pressure_source(self, source_type, sample, estimate):
725725
raise NotImplementedError("update_virtual_pressure_source not yet implemented")
726726

727727
def remove_virtual_pressure_source(self, source_type):

Diff for: tools/wptrunner/wptrunner/executors/executorwebdriver.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -684,8 +684,8 @@ def create_virtual_pressure_source(self, source_type, metadata):
684684
body.update(metadata)
685685
return self.webdriver.send_session_command("POST", "pressuresource", body)
686686

687-
def update_virtual_pressure_source(self, source_type, sample):
688-
body = {"sample": sample}
687+
def update_virtual_pressure_source(self, source_type, sample, estimate):
688+
body = {"sample": sample, "estimate": estimate}
689689
return self.webdriver.send_session_command("POST", "pressuresource/%s" % source_type, body)
690690

691691
def remove_virtual_pressure_source(self, source_type):

Diff for: tools/wptrunner/wptrunner/executors/protocol.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,7 @@ def create_virtual_pressure_source(self, source_type, metadata):
10091009
pass
10101010

10111011
@abstractmethod
1012-
def update_virtual_pressure_source(self, source_type, sample):
1012+
def update_virtual_pressure_source(self, source_type, sample, estimate):
10131013
pass
10141014

10151015
@abstractmethod

Diff for: tools/wptrunner/wptrunner/testdriver-extra.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -468,8 +468,8 @@
468468
return create_context_action("create_virtual_pressure_source", context, {source_type, metadata});
469469
};
470470

471-
window.test_driver_internal.update_virtual_pressure_source = function(source_type, sample, context=null) {
472-
return create_context_action("update_virtual_pressure_source", context, {source_type, sample});
471+
window.test_driver_internal.update_virtual_pressure_source = function(source_type, sample, estimate, context=null) {
472+
return create_context_action("update_virtual_pressure_source", context, {source_type, sample, estimate});
473473
};
474474

475475
window.test_driver_internal.remove_virtual_pressure_source = function(source_type, context=null) {

0 commit comments

Comments
 (0)