Skip to content

Commit 3bd9ff9

Browse files
authored
Better log for debugging (#46825)
We are seeing logs as below from Chromium bots. Add more information to log to make debugging easier. Two kind of error log to address here: 1) No handler for resource: '/404' 2) WebDriver was not accessible within the timeout: Bug: chromedriver:4793
1 parent c9de6fe commit 3bd9ff9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tools/third_party/pywebsocket3/pywebsocket3/request_handler.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ def parse_request(self):
219219
self._logger.info('Request basic authentication')
220220
return False
221221

222+
whole_path = self.path
222223
host, port, resource = http_header_util.parse_uri(self.path)
223224
if resource is None:
224225
self._logger.info('Invalid URI: %r', self.path)
@@ -247,7 +248,7 @@ def parse_request(self):
247248
# Fallback to default http handler for request paths for which
248249
# we don't have request handlers.
249250
if not self._options.dispatcher.get_handler_suite(self.path):
250-
self._logger.info('No handler for resource: %r', self.path)
251+
self._logger.info('No handler for resource: %r', whole_path)
251252
self._logger.info('Fallback to CGIHTTPRequestHandler')
252253
return True
253254
except dispatch.DispatchException as e:

tools/wptrunner/wptrunner/browsers/base.py

+4-5
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ def _run_server(self, group_metadata: GroupMetadata, **kwargs: Any) -> None:
359359
env=self.env,
360360
storeOutput=False)
361361

362-
self.logger.debug("Starting WebDriver: %s" % ' '.join(cmd))
362+
self.logger.info("Starting WebDriver: %s" % ' '.join(cmd))
363363
try:
364364
self._proc.run()
365365
except OSError as e:
@@ -378,13 +378,12 @@ def _run_server(self, group_metadata: GroupMetadata, **kwargs: Any) -> None:
378378
server_process=self._proc,
379379
)
380380
except Exception:
381-
self.logger.error(
382-
"WebDriver was not accessible "
383-
f"within the timeout:\n{traceback.format_exc()}")
381+
self.logger.error(f"WebDriver was not accessible within {self.init_timeout} seconds.")
382+
self.logger.error(traceback.format_exc())
384383
raise
385384
finally:
386385
self._output_handler.start(group_metadata=group_metadata, **kwargs)
387-
self.logger.debug("_run complete")
386+
self.logger.info("Webdriver started successfully.")
388387

389388
def stop(self, force: bool = False) -> bool:
390389
self.logger.debug("Stopping WebDriver")

0 commit comments

Comments
 (0)