You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The `TestDriverExecutorMixin` introduced for #13183 requires an
`is_alive()` executor method, but we forgot to add one for
`WebDriverCrashtestExecutor` [0]:
```
2025-03-17 05:05:54.246 INFO Starting runner
▶ ERROR [expected PASS] external/wpt/html/semantics/forms/the-select-element/customizable-select/nested-select-crash.html
└ → Traceback (most recent call last):
File "/Volumes/Work/s/w/ith4ri8l3q/external/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 831, in run_func
self.result = True, self.func(self.protocol, self.url, self.timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Volumes/Work/s/w/ith4ri8l3q/external/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1239, in do_crashtest
self.run_testdriver(protocol, url, timeout)
File "/Volumes/Work/s/w/ith4ri8l3q/external/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 938, in run_testdriver
is_alive = self.is_alive()
^^^^^^^^^^^^^
AttributeError: 'WebDriverCrashtestExecutor' object has no attribute 'is_alive'
```
Fixed by just inlining `protocol.is_alive()`, which is the same for all
executor types.
[0]: https://chromium-swarm.appspot.com/task?id=6fbcb3db3c2e6410
0 commit comments