Skip to content

Commit 7a9307e

Browse files
committed
servodriver: Ensure capabilities is always a non-empty value.
Signed-off-by: Josh Matthews <[email protected]>
1 parent a891f29 commit 7a9307e

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Diff for: tools/wptrunner/wptrunner/browsers/servodriver.py

+2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ def browser_kwargs(logger, test_type, run_info_data, config, **kwargs):
4848
"server_config": config,
4949
"user_stylesheets": kwargs.get("user_stylesheets"),
5050
"headless": kwargs.get("headless"),
51+
"capabilities": kwargs.get("capabilities"),
5152
}
5253

5354

5455
def executor_kwargs(logger, test_type, test_environment, run_info_data, **kwargs):
5556
rv = base_executor_kwargs(test_type, test_environment, run_info_data, **kwargs)
57+
rv['capabilities'] = {}
5658
return rv
5759

5860

Diff for: tools/wptrunner/wptrunner/executors/executorservodriver.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class ServoWebDriverTestharnessExecutor(WebDriverTestharnessExecutor):
7878
protocol_cls = ServoWebDriverProtocol
7979

8080
def __init__(self, logger, browser, server_config, timeout_multiplier=1,
81-
close_after_done=True, capabilities={}, debug_info=None,
81+
close_after_done=True, capabilities=None, debug_info=None,
8282
**kwargs):
8383
WebDriverTestharnessExecutor.__init__(self, logger, browser, server_config,
8484
timeout_multiplier, capabilities=capabilities,
@@ -96,7 +96,7 @@ class ServoWebDriverRefTestExecutor(WebDriverRefTestExecutor):
9696
protocol_cls = ServoWebDriverProtocol
9797

9898
def __init__(self, logger, browser, server_config, timeout_multiplier=1,
99-
screenshot_cache=None, capabilities={}, debug_info=None,
99+
screenshot_cache=None, capabilities=None, debug_info=None,
100100
**kwargs):
101101
WebDriverRefTestExecutor.__init__(self, logger, browser, server_config,
102102
timeout_multiplier, screenshot_cache,
@@ -114,7 +114,7 @@ class ServoWebDriverCrashtestExecutor(WebDriverCrashtestExecutor):
114114
protocol_cls = ServoWebDriverProtocol
115115

116116
def __init__(self, logger, browser, server_config, timeout_multiplier=1,
117-
screenshot_cache=None, capabilities={}, debug_info=None,
117+
screenshot_cache=None, capabilities=None, debug_info=None,
118118
**kwargs):
119119
WebDriverCrashtestExecutor.__init__(self, logger, browser, server_config,
120120
timeout_multiplier, screenshot_cache,

0 commit comments

Comments
 (0)