Skip to content

Commit 99f5bfc

Browse files
authored
Set the default device_serial argument (#45819)
It appears that WPT does not run on the Chrome Android browser of the simulator unless the '--device-serial' argument is explicitly added, after the PR[1] that introduced support for multiple emulators. The CL only sets the default value(emulator-5554) to Firefox Android. So this CL sets the default value to Chrome Android browsers as well. [1] Support multiple emulators for Android browsers (#31634) (#31634)
1 parent bda0e68 commit 99f5bfc

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tools/wpt/run.py

+2
Original file line numberDiff line numberDiff line change
@@ -565,6 +565,8 @@ def setup_kwargs(self, kwargs):
565565
if kwargs["package_name"] is None:
566566
kwargs["package_name"] = self.browser.find_binary(
567567
channel=browser_channel)
568+
if not kwargs["device_serial"]:
569+
kwargs["device_serial"] = ["emulator-5554"]
568570
if kwargs["webdriver_binary"] is None:
569571
webdriver_binary = None
570572
if not kwargs["install_webdriver"]:

0 commit comments

Comments
 (0)