Skip to content

Commit c5ca5a5

Browse files
[wptrunner] Don't honor per-request timeout for now (#46881)
This is a partial revert of #46869. Using a nondefault timeout fails with: ``` ▶ ERROR [expected OK] external/wpt/IndexedDB/idbindex-query-exception-order.html └ → WebDriverRun.run_func didn't set a result Exception in thread Thread-4: Traceback (most recent call last): File "/tmp/wpt/tools/webdriver/webdriver/transport.py", line 259, in _request previous_timeout = self._conn.gettimeout() AttributeError: 'HTTPConnection' object has no attribute 'gettimeout' ``` ... because `{get,set}timeout` are methods on `socket.socket`, not `http.client.HTTP(S)Connection`.
1 parent 8b16a57 commit c5ca5a5

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

tools/webdriver/webdriver/transport.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@ def send(self,
204204
``json.JSONEncoder`` unless specified.
205205
:param decoder: JSON decoder class, which defaults to
206206
``json.JSONDecoder`` unless specified.
207-
:param timeout: Optional timeout for the underlying socket. `None` will
208-
retain the existing timeout.
209207
:param codec_kwargs: Surplus arguments passed on to `encoder`
210208
and `decoder` on construction.
211209
@@ -233,7 +231,7 @@ def send(self,
233231
# runner thread. We use the boolean below to check for that and restart
234232
# the connection in that case.
235233
self._last_request_is_blocked = True
236-
response = self._request(method, uri, payload, headers, timeout=timeout)
234+
response = self._request(method, uri, payload, headers, timeout=None)
237235
self._last_request_is_blocked = False
238236
return Response.from_http(response, decoder=decoder, **codec_kwargs)
239237

0 commit comments

Comments
 (0)