@@ -229,88 +229,95 @@ test.describe("overlay", { tag: ["@flaky", "@fails"] }, () => {
229
229
}
230
230
} ) ;
231
231
232
- test ( "should not show initially, then show on an error, then hide on fix" , async ( {
233
- page,
234
- } ) => {
235
- const compiler = webpack ( config ) ;
236
- const devServerOptions = {
237
- port,
238
- } ;
239
- const server = new Server ( devServerOptions , compiler ) ;
232
+ test . skip (
233
+ "should not show initially, then show on an error, then hide on fix" ,
234
+ {
235
+ annotation : {
236
+ type : "@fails" ,
237
+ description : "on ubuntu and windows" ,
238
+ } ,
239
+ } ,
240
+ async ( { page } ) => {
241
+ const compiler = webpack ( config ) ;
242
+ const devServerOptions = {
243
+ port,
244
+ } ;
245
+ const server = new Server ( devServerOptions , compiler ) ;
240
246
241
- await server . start ( ) ;
247
+ await server . start ( ) ;
242
248
243
- const pathToFile = path . resolve (
244
- __dirname ,
245
- "../fixtures/overlay-config/foo.js" ,
246
- ) ;
247
- const originalCode = fs . readFileSync ( pathToFile ) ;
249
+ const pathToFile = path . resolve (
250
+ __dirname ,
251
+ "../fixtures/overlay-config/foo.js" ,
252
+ ) ;
253
+ const originalCode = fs . readFileSync ( pathToFile ) ;
248
254
249
- try {
250
- await page . goto ( `http://localhost:${ port } /` , {
251
- waitUntil : "networkidle0" ,
252
- } ) ;
255
+ try {
256
+ await page . goto ( `http://localhost:${ port } /` , {
257
+ waitUntil : "networkidle0" ,
258
+ } ) ;
253
259
254
- let pageHtml = await page . evaluate ( ( ) => document . body . outerHTML ) ;
255
- let overlayHandle = await page . $ ( "#webpack-dev-server-client-overlay" ) ;
260
+ let pageHtml = await page . evaluate ( ( ) => document . body . outerHTML ) ;
261
+ let overlayHandle = await page . $ ( "#webpack-dev-server-client-overlay" ) ;
256
262
257
- expect (
258
- await prettier . format ( pageHtml , {
259
- parser : "html" ,
260
- plugins : [ prettierHTML , prettierCSS ] ,
261
- } ) ,
262
- ) . toMatchSnapshotWithArray ( "page html initial" ) ;
263
+ expect (
264
+ await prettier . format ( pageHtml , {
265
+ parser : "html" ,
266
+ plugins : [ prettierHTML , prettierCSS ] ,
267
+ } ) ,
268
+ ) . toMatchSnapshotWithArray ( "page html initial" ) ;
263
269
264
- fs . writeFileSync ( pathToFile , "`;" ) ;
270
+ fs . writeFileSync ( pathToFile , "`;" ) ;
265
271
266
- await page . waitForSelector ( "#webpack-dev-server-client-overlay" ) ;
272
+ await page . waitForSelector ( "#webpack-dev-server-client-overlay" ) ;
267
273
268
- overlayHandle = await page . $ ( "#webpack-dev-server-client-overlay" ) ;
274
+ overlayHandle = await page . $ ( "#webpack-dev-server-client-overlay" ) ;
269
275
270
- pageHtml = await page . evaluate ( ( ) => document . body . outerHTML ) ;
276
+ pageHtml = await page . evaluate ( ( ) => document . body . outerHTML ) ;
271
277
272
- const overlayFrame = await overlayHandle . contentFrame ( ) ;
278
+ const overlayFrame = await overlayHandle . contentFrame ( ) ;
273
279
274
- const overlayHtml = await overlayFrame . evaluate (
275
- ( ) => document . body . outerHTML ,
276
- ) ;
280
+ const overlayHtml = await overlayFrame . evaluate (
281
+ ( ) => document . body . outerHTML ,
282
+ ) ;
277
283
278
- expect (
279
- await prettier . format ( pageHtml , {
280
- parser : "html" ,
281
- plugins : [ prettierHTML , prettierCSS ] ,
282
- } ) ,
283
- ) . toMatchSnapshotWithArray ( "page html with error" ) ;
284
- expect (
285
- await prettier . format ( overlayHtml , {
286
- parser : "html" ,
287
- plugins : [ prettierHTML , prettierCSS ] ,
288
- } ) ,
289
- ) . toMatchSnapshotWithArray ( "overlay html" ) ;
284
+ expect (
285
+ await prettier . format ( pageHtml , {
286
+ parser : "html" ,
287
+ plugins : [ prettierHTML , prettierCSS ] ,
288
+ } ) ,
289
+ ) . toMatchSnapshotWithArray ( "page html with error" ) ;
290
+ expect (
291
+ await prettier . format ( overlayHtml , {
292
+ parser : "html" ,
293
+ plugins : [ prettierHTML , prettierCSS ] ,
294
+ } ) ,
295
+ ) . toMatchSnapshotWithArray ( "overlay html" ) ;
290
296
291
- fs . writeFileSync ( pathToFile , originalCode ) ;
297
+ fs . writeFileSync ( pathToFile , originalCode ) ;
292
298
293
- await page . waitForSelector ( "#webpack-dev-server-client-overlay" , {
294
- hidden : true ,
295
- } ) ;
299
+ await page . waitForSelector ( "#webpack-dev-server-client-overlay" , {
300
+ hidden : true ,
301
+ } ) ;
296
302
297
- pageHtml = await page . evaluate ( ( ) => document . body . outerHTML ) ;
298
- overlayHandle = await page . $ ( "#webpack-dev-server-client-overlay" ) ;
303
+ pageHtml = await page . evaluate ( ( ) => document . body . outerHTML ) ;
304
+ overlayHandle = await page . $ ( "#webpack-dev-server-client-overlay" ) ;
299
305
300
- expect (
301
- await prettier . format ( pageHtml , {
302
- parser : "html" ,
303
- plugins : [ prettierHTML , prettierCSS ] ,
304
- } ) ,
305
- ) . toMatchSnapshotWithArray ( "page html after fix" ) ;
306
- } catch ( error ) {
307
- fs . writeFileSync ( pathToFile , originalCode ) ;
308
- throw error ;
309
- } finally {
310
- await server . stop ( ) ;
311
- fs . writeFileSync ( pathToFile , originalCode ) ;
312
- }
313
- } ) ;
306
+ expect (
307
+ await prettier . format ( pageHtml , {
308
+ parser : "html" ,
309
+ plugins : [ prettierHTML , prettierCSS ] ,
310
+ } ) ,
311
+ ) . toMatchSnapshotWithArray ( "page html after fix" ) ;
312
+ } catch ( error ) {
313
+ fs . writeFileSync ( pathToFile , originalCode ) ;
314
+ throw error ;
315
+ } finally {
316
+ await server . stop ( ) ;
317
+ fs . writeFileSync ( pathToFile , originalCode ) ;
318
+ }
319
+ } ,
320
+ ) ;
314
321
315
322
// TODO: Fix this test, it fails on re-run
316
323
test . skip ( "should not show initially, then show on an error, then show other error, then hide on fix" , async ( {
0 commit comments