Idea: Better typing for log.args

[tahos81]

This is the current GetInferredLogValues

type GetInferredLogValues<
  abiEvent extends AbiEvent | undefined = undefined,
  abi extends Abi | readonly unknown[] | undefined = abiEvent extends AbiEvent
    ? [abiEvent]
    : undefined,
  eventName extends string | undefined = abiEvent extends AbiEvent
    ? abiEvent['name']
    : undefined,
  strict extends boolean | undefined = undefined,
  _EventNames extends string = abi extends Abi
    ? Abi extends abi
      ? string
      : ExtractAbiEventNames<abi>
    : string,
> = abi extends Abi
  ? eventName extends string
    ? {
        args: GetEventArgs<
          abi,
          eventName,
          {
            EnableUnion: false
            IndexedOnly: false
            Required: strict extends boolean ? strict : false
          }
        >
        /** The event name decoded from `topics`. */
        eventName: eventName
        /** List of order-dependent topics */
        topics: GetTopics<abiEvent, abi, eventName>
      }
    : {
        [name in _EventNames]: {
          args: GetEventArgs<
            abi,
            name,
            {
              EnableUnion: false
              IndexedOnly: false
              Required: strict extends boolean ? strict : false
            }
          >
          /** The event name decoded from `topics`. */
          eventName: name
          /** List of order-dependent topics */
          topics: GetTopics<abiEvent, abi, name>
        }
      }[_EventNames]
  : {
      topics: [Hex, ...Hex[]] | []
    }

since it only uses eventName for GetEventArgs and not abiEvent resulting log.args becomes a union type when your ABI has two events with the same name but different signature.

I believe something like this would solve the issue:

@@ -95,27 +95,28 @@ type GetInferredLogValues<
       : ExtractAbiEventNames<abi>
     : string,
 > = abi extends Abi
-  ? eventName extends string
+  ? abiEvent extends AbiEvent
     ? {
         args: GetEventArgs<
           abi,
-          eventName,
+          abiEvent['name'],
           {
             EnableUnion: false
             IndexedOnly: false
             Required: strict extends boolean ? strict : false
-          }
+          },
+          abiEvent
         >
         /** The event name decoded from `topics`. */
-        eventName: eventName
+        eventName: abiEvent['name']
         /** List of order-dependent topics */
-        topics: GetTopics<abiEvent, abi, eventName>
+        topics: GetTopics<abiEvent, abi, abiEvent['name']>
       }
-    : {
-        [name in _EventNames]: {
+    : eventName extends string
+      ? {
           args: GetEventArgs<
             abi,
-            name,
+            eventName,
             {
               EnableUnion: false
               IndexedOnly: false
@@ -123,11 +124,27 @@ type GetInferredLogValues<
             }
           >
           /** The event name decoded from `topics`. */
-          eventName: name
+          eventName: eventName
           /** List of order-dependent topics */
-          topics: GetTopics<abiEvent, abi, name>
+          topics: GetTopics<abiEvent, abi, eventName>
         }
-      }[_EventNames]
+      : {
+          [name in _EventNames]: {
+            args: GetEventArgs<
+              abi,
+              name,
+              {
+                EnableUnion: false
+                IndexedOnly: false
+                Required: strict extends boolean ? strict : false
+              }
+            >
+            /** The event name decoded from `topics`. */
+            eventName: name
+            /** List of order-dependent topics */
+            topics: GetTopics<abiEvent, abi, name>
+          }
+        }[_EventNames]
   : {
       topics: [Hex, ...Hex[]] | []
     }