Skip to content

vkCmdResetQueryPool called in TracyVkCollect despite using VK_EXT_host_query_reset #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxime-modulopi opened this issue May 27, 2025 · 2 comments · May be fixed by #1065
Open

vkCmdResetQueryPool called in TracyVkCollect despite using VK_EXT_host_query_reset #1053

maxime-modulopi opened this issue May 27, 2025 · 2 comments · May be fixed by #1065

Comments

@maxime-modulopi
Copy link

vkCmdResetQueryPool is called instead of vkResetQueryPool in TracyVkCollect even when the context was created with TracyVkContextHostCalibrated:

VK_FUNCTION_WRAPPER( vkCmdResetQueryPool( cmdbuf, m_query, wrappedTail, cnt ) );

I believe forcing the "Cmd" variant is not needed here?

Also, this would allow removing the cmdbuf parameter of TracyVkCollect when host query reset are used, making it more flexible in when it is called.

@wolfpld
Copy link
Owner

wolfpld commented Jun 7, 2025

vkCmdResetQueryPool is Vulkan 1.0, vkResetQueryPool is 1.2. Before you ask, Android.

@maxime-modulopi
Copy link
Author

maxime-modulopi commented Jun 7, 2025

Yes but Tracy already supports creating a TracyVkCtx with host resets via TracyVkContextHostCalibrated (which already calls vkResetQueryPool in its constructor).

Similarly to this, I would have expected to be able to use vkResetQueryPool inside TracyVkCollect too (only if the context was created via TracyVkContextHostCalibrated obviously).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants