Remove unused Unixext.Direct module

Signed-off-by: Rob Hoes <[email protected]>

Author: robhoes

ocaml/libs/xapi-stdext/lib/xapi-stdext-unix/dune

@@ -16,7 +16,5 @@
     (language c)
     (names
       blkgetsize_stubs
-      unixext_open_stubs
-      unixext_stubs
-      unixext_write_stubs))
+      unixext_stubs))
 )

ocaml/libs/xapi-stdext/lib/xapi-stdext-unix/unixext.ml

@@ -925,35 +925,6 @@ let test_open n =
     done
   )
 
-module Direct = struct
-  type t = Unix.file_descr
-
-  external openfile : string -> Unix.open_flag list -> Unix.file_perm -> t
-    = "stub_stdext_unix_open_direct"
-
-  let close = Unix.close
-
-  let with_openfile path flags perms f =
-    let t = openfile path flags perms in
-    finally (fun () -> f t) (fun () -> close t)
-
-  external unsafe_write : t -> bytes -> int -> int -> int
-    = "stub_stdext_unix_write"
-
-  let write fd buf ofs len =
-    if ofs < 0 || len < 0 || ofs > Bytes.length buf - len then
-      invalid_arg "Unixext.write"
-    else
-      unsafe_write fd buf ofs len
-
-  let copy_from_fd ?limit socket fd =
-    copy_file_internal ?limit (Unix.read socket) (write fd)
-
-  let fsync x = fsync x
-
-  let lseek fd x cmd = Unix.LargeFile.lseek fd x cmd
-end
-
 (* --------------------------------------------------------------------------------------- *)
 
 module Daemon = struct

ocaml/libs/xapi-stdext/lib/xapi-stdext-unix/unixext.mli

@@ -266,36 +266,6 @@ val test_open : int -> unit
   The file descriptors will stay open until the program exits.
  *)
 
-module Direct : sig
-  (** Perform I/O in O_DIRECT mode using 4KiB page-aligned buffers *)
-
-  (** represents a file open in O_DIRECT mode *)
-  type t
-
-  val openfile : string -> Unix.open_flag list -> Unix.file_perm -> t
-  (** [openfile name flags perm] behaves the same as [Unix.openfile] but includes the O_DIRECT flag *)
-
-  val close : t -> unit
-  (** [close t] closes [t], a file open in O_DIRECT mode *)
-
-  val with_openfile :
-    string -> Unix.open_flag list -> Unix.file_perm -> (t -> 'a) -> 'a
-  (** [with_openfile name flags perm f] opens [name], applies the result to [f] and closes *)
-
-  val write : t -> bytes -> int -> int -> int
-  (** [write t buf ofs len] writes [len] bytes at offset [ofs] from buffer [buf] to
-      		[t] using page-aligned buffers. *)
-
-  val copy_from_fd : ?limit:int64 -> Unix.file_descr -> t -> int64
-  (** [copy_from_fd ?limit fd t] copies from [fd] to [t] up to [limit] *)
-
-  val fsync : t -> unit
-  (** [fsync t] commits all outstanding writes, throwing an error if necessary. *)
-
-  val lseek : t -> int64 -> Unix.seek_command -> int64
-  (** [lseek t offset command]: see Unix.LargeFile.lseek *)
-end
-
 module Daemon : sig
   (** OCaml interface to libsystemd.
 

ocaml/libs/xapi-stdext/lib/xapi-stdext-unix/unixext_open_stubs.c

@@ -534,6 +534,11 @@
                 <description>A Failure occurred accessing an API object</description>
                 <value>153</value>
         </code>
+        <code>
+                <name>APIProtocolError</name>
+                <description>A protocol error was received when accessing the API</description>
+                <value>154</value>
+        </code>
 
         <!-- Netapp Specific Error codes -->
         <code>