Skip to content

Commit d94ab88

Browse files
committed
#426: Can't filter by traits on ITheoryDataRow
1 parent 9154f3f commit d94ab88

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/xunit.runner.visualstudio/VsTestRunner.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,9 @@ async Task DiscoverTests<TVisitor>(
207207
ConfigReader.Load(assembly.Configuration, assembly.AssemblyFileName, assembly.ConfigFileName, configWarnings);
208208
runSettings.CopyTo(assembly.Configuration);
209209

210-
// IDE users get pre-enumeated theories by default
211-
if (testPlatformContext.DesignMode)
212-
assembly.Configuration.PreEnumerateTheories ??= true;
210+
// Pre-enumerate theories by default, so that we can see all traits, including those that come from
211+
// ITheoryDataRow in v3. See: https://github.com/xunit/visualstudio.xunit/issues/426
212+
assembly.Configuration.PreEnumerateTheories ??= true;
213213

214214
foreach (var warning in configWarnings)
215215
logger.LogWarning("{0}", warning);

0 commit comments

Comments
 (0)