Skip to content

ClickHouse 3970: Add setting min_merge_bytes_to_use_direct_io #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2018

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Sep 12, 2018

Hack in code :(. But changes are very small. The only good solution is to split MergeTreeBlockInputStream, as said in comment https://github.com/yandex/ClickHouse/blob/master/dbms/src/Storages/MergeTree/MergeTreeBlockInputStream.h#L15.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@alexey-milovidov alexey-milovidov merged commit 4af3df9 into master Sep 12, 2018
@alexey-milovidov
Copy link
Member

Ok.

Hack in code :(. But changes are very small. The only good solution is to split MergeTreeBlockInputStream, as said in comment https://github.com/yandex/ClickHouse/blob/master/dbms/src/Storages/MergeTree/MergeTreeBlockInputStream.h#L15.

Note that the methods createReadBufferFromFileBase and createWriteBufferFromFileBase accept both estimated_size and aio_threshold as parameters, with the only purpose to do simple comparison.

I think, it will be better to pass just single parameter named use_direct_io, and move all logic with thresholds outside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants