Issue 3269 Fix incorrect OR evaluation when multiples ORs are optimized to IN #3339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repared set indexation works correctly
| /// Get range min/max from all literals x1...xN, which will be used as tuple_functions' range | ||
| if (min_range_first == nullptr || min_range_first > operands[1]->range.first) | ||
| min_range_first = operands[1]->range.first; | ||
| if (max_range_second < operands[1]->range.second) |
There was a problem hiding this comment.
|
Thank you! PS. Maybe we should get rid of AST range and use something other for prepared sets indexation. |
|
Please add a test in separate PR. |
Closed
|
Why don't add a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3269 In this case when multiple equality evaluation are bundled into one IN set evaluation, since tuple_function is generated from optimizer, it doesn't have a proper range which is later used as indexation key for prepared set.
Add fake range for tuple ASTFunction generated by Optimizer so that prepared set indexation works correctly.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en