Wait for write propagation after creating an OS Login SSH key (GoogleCloudPlatform#13353)

ericdand · yerniyazN · commit 9bc31ae36896 · 2025-03-18T00:12:03.000+01:00
diff --git a/mmv1/products/oslogin/SSHPublicKey.yaml b/mmv1/products/oslogin/SSHPublicKey.yaml
@@ -35,7 +35,7 @@ timeouts:
   delete_minutes: 20
 custom_code:
   pre_create: 'templates/terraform/pre_create/os_login_ssh_public_key.go.tmpl'
-  post_create: 'templates/terraform/post_create/sshkeyfingerprint.go.tmpl'
+  post_create: 'templates/terraform/post_create/sshkeyfingerprint_and_sleep.go.tmpl'
 # Skip sweeper since due to URL containing user ID
 exclude_sweeper: true
 examples:
diff --git a/mmv1/templates/terraform/post_create/sshkeyfingerprint_and_sleep.go.tmpl b/mmv1/templates/terraform/post_create/sshkeyfingerprint_and_sleep.go.tmpl
@@ -20,4 +20,7 @@ id, err = tpgresource.ReplaceVars(d, config, "users/{{"{{"}}user{{"}}"}}/sshPubl
 if err != nil {
 	return fmt.Errorf("Error constructing id: %s", err)
 }
-d.SetId(id)
+d.SetId(id)
+
+// Wait 10s for write propagation; should be usually done in ~7s max.
+time.Sleep(10 * time.Second)

Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,7 @@ id, err = tpgresource.ReplaceVars(d, config, "users/{{"{{"}}user{{"}}"}}/sshPubl`
`20`	`20`	`if err != nil {`
`21`	`21`	`return fmt.Errorf("Error constructing id: %s", err)`
`22`	`22`	`}`
`23`		`-d.SetId(id)`
	`23`	`+d.SetId(id)`
	`24`	`+`
	`25`	`+// Wait 10s for write propagation; should be usually done in ~7s max.`
	`26`	`+time.Sleep(10 * time.Second)`