Polishing.

Consistent offending method name format.

Use String.format(…) instead of formatted(…).

Original pull request: spring-projects#4547
See spring-projects#4546

Author: mp911de

Diff for: spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/MongoQueryMethod.java

@@ -493,25 +493,32 @@ public void verify() {
 			if (isCollectionQuery() || isScrollQuery() || isSliceQuery() || isPageQuery() || isGeoNearQuery()
 					|| !isNumericOrVoidReturnValue()) { //
 				throw new IllegalStateException(
-						String.format("Update method may be void or return a numeric value (the number of updated documents)."
-								+ "Offending method: %s", method));
+						String.format(
+								"Update method may be void or return a numeric value (the number of updated documents)."
+										+ " Offending Method: %s.%s",
+								ClassUtils.getShortName(method.getDeclaringClass()), method.getName()));
 			}
 
 			if (hasAnnotatedUpdate()) { // must define either an update or an update pipeline
 				if (!StringUtils.hasText(getUpdateSource().update()) && ObjectUtils.isEmpty(getUpdateSource().pipeline())) {
 					throw new IllegalStateException(
-							String.format("Update method must define either 'Update#update' or 'Update#pipeline' attribute;"
-									+ " Offending method: %s", method));
+							String.format(
+									"Update method must define either 'Update#update' or 'Update#pipeline' attribute;"
+											+ " Offending Method: %s.%s",
+									ClassUtils.getShortName(method.getDeclaringClass()), method.getName()));
 				}
 			}
 		}
+
 		if (hasAnnotatedAggregation()) {
 			for (String stage : getAnnotatedAggregation()) {
 				if (BsonUtils.isJsonArray(stage)) {
-					throw new IllegalStateException("""
-							Invalid aggregation pipeline. Please split Aggregation.pipeline from "[{...}, {...}]" to "{...}", "{...}".
-							Offending Method: %s.%s
-							""".formatted(method.getDeclaringClass().getSimpleName(), method.getName()));
+					throw new IllegalStateException(String.format(
+							"""
+									Invalid aggregation pipeline. Please split the definition from @Aggregation("[{...}, {...}]") to @Aggregation({ "{...}", "{...}" }).
+									Offending Method: %s.%s
+									""",
+							ClassUtils.getShortName(method.getDeclaringClass()), method.getName()));
 				}
 			}
 		}

Diff for: spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/query/MongoQueryMethodUnitTests.java

@@ -359,9 +359,9 @@ void detectsReadPreferenceForAggregation() throws Exception {
 	}
 
 	@Test // GH-4546
-	void errorsOnInvalidAggregation() throws Exception {
+	void errorsOnInvalidAggregation() {
 
-		assertThatExceptionOfType(IllegalStateException.class) //
+		assertThatIllegalStateException() //
 				.isThrownBy(() -> queryMethod(InvalidAggregationMethodRepo.class, "findByAggregation").verify()) //
 				.withMessageContaining("Invalid aggregation") //
 				.withMessageContaining("findByAggregation");